From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8664BC43461 for ; Tue, 1 Sep 2020 15:25:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6446220BED for ; Tue, 1 Sep 2020 15:25:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598973942; bh=dt0uPCgqA2UkzByRpvH836C/HijSVdlozfTi2rrAOao=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=bWRlBOMCPpYR/EKfvyuLnw9BJI8XC5ZoSggYJxQKwC13c90DXWjAh0hi5SvtbNzIX 4XohGz6f5OZfEAhnEAPVhznv/0vey6XY9zJpJpV6Yj+1ubZyqullNfiv/+dWHRnugY RDR4mR7qgQjTjjMbQKcFhc+0xt6aiqF57xXBPVvU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730057AbgIAPZi (ORCPT ); Tue, 1 Sep 2020 11:25:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:50310 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730052AbgIAPZh (ORCPT ); Tue, 1 Sep 2020 11:25:37 -0400 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 02D64206FA; Tue, 1 Sep 2020 15:25:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598973936; bh=dt0uPCgqA2UkzByRpvH836C/HijSVdlozfTi2rrAOao=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=C7uOrhsVqPRlHMAta5eV8ksbBFNCUpIBGOOrdMg7foI7teaTc1REKWNu5TxY3Es0S e6lOqcIlrvmJToIoMes2VDNaHEZjlMpxy29Jma4MlAk0c72oK1cl9LoPBjQcrjLxOI cCjvgm2xS9BjFEOYNSVYWDzOwFwvWS5MHeBnvW3M= Received: by mail-ej1-f53.google.com with SMTP id d26so2276846ejr.1; Tue, 01 Sep 2020 08:25:35 -0700 (PDT) X-Gm-Message-State: AOAM531FcbFJvbC9qYlWLcLIsQGPEPf1ZlCIOas2rX/18AIq1+86lLu2 KEXcGNFGpHeRmJUejmenw7AyQ/fliVpl/sE8a3g= X-Google-Smtp-Source: ABdhPJzh1hNetH5rZ60C9AUx80r4SPqL6nutQWfXz6QlHt16bwsP6Lk4YkuJbUpSKMu3AEV2K/P421eyp+7Rtv3kzNc= X-Received: by 2002:a17:906:9356:: with SMTP id p22mr1858821ejw.119.1598973934455; Tue, 01 Sep 2020 08:25:34 -0700 (PDT) MIME-Version: 1.0 References: <267a81e550a0b5d479c82b5908e2a2caa4c9c874.1597061474.git.guillaume.tucker@collabora.com> In-Reply-To: From: Krzysztof Kozlowski Date: Tue, 1 Sep 2020 17:25:23 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/4] ARM: exynos: clear L310_AUX_CTRL_NS_LOCKDOWN in default l2c_aux_val To: Guillaume Tucker Cc: Russell King , Kukjin Kim , Rob Herring , kernel@collabora.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "linux-samsung-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 1 Sep 2020 at 16:42, Guillaume Tucker wrote: > > On 01/09/2020 14:51, Krzysztof Kozlowski wrote: > > On Tue, 1 Sep 2020 at 15:45, Krzysztof Kozlowski wrote: > >> > >> On Tue, 1 Sep 2020 at 15:34, Guillaume Tucker > >> wrote: > >>> > >>> Hi Krzysztof, Russell, > >>> > >>> On 10/08/2020 13:22, Guillaume Tucker wrote: > >>>> The L310_AUX_CTRL_NS_LOCKDOWN flag is set during the L2C enable > >>>> sequence. There is no need to set it in the default register value, > >>>> this was done before support for it was implemented in the code. It > >>>> is not set in the hardware initial value either. > >>>> > >>>> Clean this up by removing this flag from the default l2c_aux_val, and > >>>> add it to the l2c_aux_mask to print an alert message if it was already > >>>> set before the kernel initialisation. > >>>> > >>>> Signed-off-by: Guillaume Tucker > >>>> --- > >>>> > >>>> Notes: > >>>> v2: fix flag name L310_AUX_CTRL_NS_LOCKDOWN > >>>> > >>>> arch/arm/mach-exynos/exynos.c | 4 ++-- > >>>> 1 file changed, 2 insertions(+), 2 deletions(-) > >>> > >>> I believe this v2 series has addressed all previous comments and > >>> you were waiting for the 5.9 merge window to end. The patches > >>> all still apply cleanly on v5.9-rc3. Do you want me to resend > >>> the series anyway or is there anything else needed at this point? > >>> > >>> Maybe one thing that wasn't completely clear in v1 was whether > >>> patch 2/4 was the right approach. I've explained the reason > >>> behind it but didn't get a final reply from Russell[1]. > >> > >> I am sorry, my bad. I already applied this one and 3/4 (dts). > >> Apparently I forgot to reply with confirmation and Patchwork did not > >> notify you for some reason. > > No problem, I see them in linux-next now. Thanks! > > >> Patch 2/4 does not look like one for me so I would need ack from > >> Russell to take. Did you submit it to the ARM patches queue? > > I've CC-ed linux-arm-kernel@lists.infradead.org on the whole > series. Did you mean anything else by the ARM patches queue? Unless anything changed, so far all ARM-core related patches had to be submitted to Russell's system. I didn't submit anything for 3 years so maybe something changed... https://www.arm.linux.org.uk/developer/patches/ Best regards, Krzysztof