devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Heiko Thiery <heiko.thiery@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>, Li Yang <leoyang.li@nxp.com>,
	Michael Walle <michael@walle.cc>
Subject: Re: [PATCH 2/2] arm64: dts: fsl: add support for Kontron pitx-imx8m board
Date: Mon, 22 Feb 2021 19:38:47 +0100	[thread overview]
Message-ID: <CAJKOXPdhbwpEHA+h3706NXf0uRhyu8VVC++K8WpzA6h2=8PK8Q@mail.gmail.com> (raw)
In-Reply-To: <CAEyMn7YPNRDbPH84wg2s+r2F6Fo=0DJOUd-R03Fg=6_CxgknSg@mail.gmail.com>

On Mon, 22 Feb 2021 at 10:09, Heiko Thiery <heiko.thiery@gmail.com> wrote:
> > > > > +
> > > > > +     pcie0_refclk: pcie0-refclk {
> > > >
> > > > Generic node names (from the dt spec candidate is "clock").
> > >
> > > Should I simply set the node name to pcie0-clock? And pcie1-clock for
> > > the next one?
> >
> > I am fine with "pcie0-clock" or just "clock-0".
>
> I saw now that in "imx8mq-zii-ultra.dtsi" the name
> "clock-pcie0-refclk" is used. Can I use the same?

It's not that generic anymore - but specific, but it's also not that
important, so go ahead.

> > >
> > > When I run "make dtbs_check" it runs quite a long time and stops with
> > > an error. But as far as I can say there is an error coming from the
> > > included "imx8mq.dtsi".
> > >
> > > You can see the output here: https://pastebin.com/raw/iU2geBDh
> >
> > Looks fine (except the error tool :) ).
>
> What do you mean with error tool?

I lost some words on the wire - I meant: "except the error from the
tool itself".

Best regards,
Krzysztof

  reply	other threads:[~2021-02-22 19:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-18 12:33 [PATCH 0/2] add Kontron pITX-imx8m board Heiko Thiery
2021-02-18 12:33 ` [PATCH 1/2] dt-bindings: arm: fsl: " Heiko Thiery
2021-02-18 12:40   ` Michael Walle
2021-02-18 12:33 ` [PATCH 2/2] arm64: dts: fsl: add support for Kontron pitx-imx8m board Heiko Thiery
2021-02-18 12:50   ` Michael Walle
2021-02-18 14:37     ` Heiko Thiery
2021-02-21 12:11   ` Krzysztof Kozlowski
2021-02-22  7:46     ` Heiko Thiery
2021-02-22  8:40       ` Krzysztof Kozlowski
2021-02-22  9:08         ` Heiko Thiery
2021-02-22 18:38           ` Krzysztof Kozlowski [this message]
2021-02-22 19:02             ` Heiko Thiery

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJKOXPdhbwpEHA+h3706NXf0uRhyu8VVC++K8WpzA6h2=8PK8Q@mail.gmail.com' \
    --to=krzk@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=heiko.thiery@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael@walle.cc \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).