From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH 4/8] ASoC: samsung: i2s: Define the parameters list for SAMSUNG_I2S_OPCLK Date: Mon, 12 Feb 2018 11:00:50 +0100 Message-ID: References: <20180205154403.13520-1-s.nawrocki@samsung.com> <20180205154403.13520-5-s.nawrocki@samsung.com> <7f86ec02-2235-7622-9298-f6edd367edb2@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <7f86ec02-2235-7622-9298-f6edd367edb2@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org To: Sylwester Nawrocki Cc: broonie@kernel.org, lgirdwood@gmail.com, alsa-devel@alsa-project.org, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, jcsing.lee@samsung.com, sbkim73@samsung.com, linux-kernel@vger.kernel.org, =?UTF-8?B?QmFydMWCb21pZWogxbtvxYJuaWVya2lld2ljeg==?= , Marek Szyprowski List-Id: devicetree@vger.kernel.org On Wed, Feb 7, 2018 at 5:23 PM, Sylwester Nawrocki wrote: > On 02/06/2018 01:26 PM, Krzysztof Kozlowski wrote: >> On Mon, Feb 5, 2018 at 4:43 PM, Sylwester Nawrocki >> wrote: > >>> diff --git a/sound/soc/samsung/i2s.h b/sound/soc/samsung/i2s.h >>> index 79781de2f247..a9832a9555cb 100644 >>> --- a/sound/soc/samsung/i2s.h >>> +++ b/sound/soc/samsung/i2s.h >>> @@ -16,11 +16,16 @@ >>> #define SAMSUNG_I2S_DAI "samsung-i2s" >>> #define SAMSUNG_I2S_DAI_SEC "samsung-i2s-sec" >>> >>> -#define SAMSUNG_I2S_DIV_BCLK 1 >>> +#define SAMSUNG_I2S_DIV_BCLK 1 >>> >>> -#define SAMSUNG_I2S_RCLKSRC_0 0 >>> -#define SAMSUNG_I2S_RCLKSRC_1 1 >>> +#define SAMSUNG_I2S_RCLKSRC_0 0 >>> +#define SAMSUNG_I2S_RCLKSRC_1 1 >>> #define SAMSUNG_I2S_CDCLK 2 >>> +/* Operation clock for IIS logic */ >>> #define SAMSUNG_I2S_OPCLK 3 >>> +#define SAMSUNG_I2S_OPCLK_CDCLK_OUT 0 /* CODEC clock out */ >>> +#define SAMSUNG_I2S_OPCLK_CDCLK_IN 1 /* CODEC clock in */ >>> +#define SAMSUNG_I2S_OPCLK_BCLK_OUT 2 /* Bit clock out */ >>> +#define SAMSUNG_I2S_OPCLK_PCLK 3 /* Audio bus clock */ >>> >>> #endif /* __SND_SOC_SAMSUNG_I2S_H */ >> >> This part of patch seems to be unrelated (and it includes some cleanups). > > This is actually the main part of the patch, an API exported to other > drivers. You are right, I looked at it without the context of 5/8 and I assumed you are changing existing user of the defines... > The whitespace changes are for keeping the alignment uniform, > I could just drop them. Let it be then. Acked-by: Krzysztof Kozlowski Best regards, Krzysztof