devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	 Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org, aiqun.yu@oss.qualcomm.com,
	 tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com,
	 yijie.yang@oss.qualcomm.com,
	Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>,
	 Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>
Subject: Re: [PATCH 10/20] arm64: dts: qcom: Add PMH0104 pmic dtsi
Date: Thu, 25 Sep 2025 16:59:51 +0900	[thread overview]
Message-ID: <CAJKOXPetzYdOvYkzeWmm9pVM1MwJhng4JLn2jsoAuey4jtfrqQ@mail.gmail.com> (raw)
In-Reply-To: <20250924-knp-dts-v1-10-3fdbc4b9e1b1@oss.qualcomm.com>

On Thu, 25 Sept 2025 at 09:17, Jingyi Wang <jingyi.wang@oss.qualcomm.com> wrote:
>
> From: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>
>
> Add base DTS file for PMH0104 inclduing temp-alarm and GPIO nodes.
>
> Signed-off-by: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>
> Signed-off-by: Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>
> Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/pmh0104.dtsi | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/pmh0104.dtsi b/arch/arm64/boot/dts/qcom/pmh0104.dtsi
> new file mode 100644
> index 000000000000..f5393fdebe95
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/pmh0104.dtsi
> @@ -0,0 +1,33 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> + */
> +
> +#include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/spmi/spmi.h>
> +
> +&spmi_bus1 {
> +       pmh0104_j_e1: pmic@PMH0104_J_E1_SID {


This might be fine for Kaanapali, but it's wrong for Glymur.

We discussed it already and I'm surprised you come with completely
different solution, not talking with the community, not aligning to
solve it properly.

Judging by other patches sent now, I recommend to drop it.

And instead just join the talks... Otherwise how am I suppose to look
at this? Everything I said should be repeated?

Best regards,
Krzysztof

  reply	other threads:[~2025-09-25  8:00 UTC|newest]

Thread overview: 135+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-25  0:17 [PATCH 00/20] arm64: dts: qcom: Introduce Kaanapali platform device tree Jingyi Wang
2025-09-25  0:17 ` [PATCH 01/20] dt-bindings: arm: qcom: Document Kaanapali SoC and its reference boards Jingyi Wang
2025-10-06  9:54   ` Krzysztof Kozlowski
2025-10-06 10:24     ` Krzysztof Kozlowski
2025-10-14  5:13       ` Jingyi Wang
2025-09-25  0:17 ` [PATCH 02/20] arm64: dts: qcom: Introduce Kaanapali SoC Jingyi Wang
2025-09-25  3:22   ` Dmitry Baryshkov
2025-10-14 16:43     ` Taniya Das
2025-10-14 11:46   ` Akhil P Oommen
2025-11-04  9:04     ` Jingyi Wang
2025-11-04 12:54       ` Konrad Dybcio
2025-11-05  7:30         ` Jingyi Wang
2025-11-05 10:13           ` Konrad Dybcio
2025-11-20  6:53   ` Komal Bajaj
2025-11-20  7:22     ` Jingyi Wang
2025-09-25  0:17 ` [PATCH 03/20] arm64: dts: qcom: kaanapali: Add base MTP board Jingyi Wang
2025-09-25  3:18   ` Dmitry Baryshkov
2025-09-25  7:17     ` Aiqun(Maria) Yu
2025-09-25  9:44   ` Konrad Dybcio
2025-09-25  0:17 ` [PATCH 04/20] arm64: dts: qcom: kaanapali: Add support for PCIe0 on Kaanapali Jingyi Wang
2025-09-25 10:56   ` Konrad Dybcio
2025-10-06 14:23   ` Krzysztof Kozlowski
2025-10-07  1:24     ` Dmitry Baryshkov
2025-10-07  1:46       ` Krzysztof Kozlowski
2025-10-08 19:04         ` Dmitry Baryshkov
2025-09-25  0:17 ` [PATCH 05/20] arm64: dts: qcom: kaanapali: Add SDC2 nodes for Kaanapali soc Jingyi Wang
2025-09-25  0:17 ` [PATCH 06/20] arm64: dts: qcom: kaanapali: Add USB support for Kaanapali SoC Jingyi Wang
2025-09-25  1:50   ` Krzysztof Kozłowski
2025-09-25  7:39     ` Aiqun(Maria) Yu
2025-09-25  8:24       ` Krzysztof Kozłowski
2025-09-25  8:32       ` Krzysztof Kozlowski
2025-09-25  9:01         ` Krzysztof Kozlowski
2025-09-25 16:49           ` Dmitry Baryshkov
2025-09-25 18:26       ` Trilok Soni
2025-09-26 13:04         ` Konrad Dybcio
2025-09-25 13:57     ` Bjorn Andersson
2025-09-25 14:12       ` Krzysztof Kozlowski
2025-09-25 21:31       ` Rob Herring
2025-09-26 13:21         ` Konrad Dybcio
2025-09-26 14:47           ` Rob Herring
2025-09-29  6:06             ` Aiqun(Maria) Yu
2025-09-29  7:19               ` Dmitry Baryshkov
2025-09-25  3:20   ` Dmitry Baryshkov
2025-09-25  7:49     ` Aiqun(Maria) Yu
2025-09-25  9:46       ` Konrad Dybcio
2025-09-25  0:17 ` [PATCH 07/20] arm64: dts: qcom: kaanapali: Add remoteprocs " Jingyi Wang
2025-09-30 17:24   ` Alexey Klimov
2025-11-04  8:59     ` Jingyi Wang
2025-11-04 10:01       ` Kumari Pallavi
2025-11-04 13:25         ` Alexey Klimov
2025-09-25  0:17 ` [PATCH 08/20] arm64: dts: qcom: Add PMK8850 pmic dtsi Jingyi Wang
2025-09-25 12:20   ` Konrad Dybcio
2025-09-25  0:17 ` [PATCH 09/20] arm64: dts: qcom: Add PMH0101 " Jingyi Wang
2025-09-25 12:20   ` Konrad Dybcio
2025-10-09 13:47     ` Jishnu Prakash
2025-09-25  0:17 ` [PATCH 10/20] arm64: dts: qcom: Add PMH0104 " Jingyi Wang
2025-09-25  7:59   ` Krzysztof Kozlowski [this message]
2025-09-25 12:21     ` Konrad Dybcio
2025-09-29  6:51       ` Aiqun(Maria) Yu
2025-09-25  0:17 ` [PATCH 11/20] arm64: dts: qcom: Add PMH0110 " Jingyi Wang
2025-09-25  0:17 ` [PATCH 12/20] arm64: dts: qcom: kaanapali: Add misc features Jingyi Wang
2025-09-25  0:17 ` [PATCH 13/20] arm64: dts: qcom: kaanapali: Add QUPv3 configuration for serial engines Jingyi Wang
2025-09-25 12:28   ` Konrad Dybcio
2025-09-25 13:19     ` Krzysztof Kozlowski
2025-09-29  3:05       ` Jingyi Wang
2025-09-29  5:42     ` Jingyi Wang
2025-09-29  6:41     ` Aiqun(Maria) Yu
2025-09-29 13:11       ` Konstantin Ryabitsev
2025-09-30  2:14         ` Aiqun(Maria) Yu
2025-09-25  0:17 ` [PATCH 14/20] arm64: dts: qcom: kaanapali-mtp: Enable more features Jingyi Wang
2025-09-25  2:09   ` Dmitry Baryshkov
2025-09-25  9:48     ` Konrad Dybcio
2025-09-26  9:11     ` Ronak Raheja
2025-09-26 11:44       ` Konrad Dybcio
2025-09-26 13:46       ` Dmitry Baryshkov
2025-09-29  3:24     ` Jingyi Wang
2025-09-25  8:03   ` Eugen Hristev
2025-10-09 13:54     ` Jishnu Prakash
2025-10-09 14:58       ` Eugen Hristev
2025-10-09 16:28         ` Dmitry Baryshkov
2025-10-10 10:54           ` Jishnu Prakash
2025-10-10 14:02             ` Eugen Hristev
2025-10-13 16:21               ` Kamal Wadhwa
2025-09-25  0:17 ` [PATCH 15/20] arm64: dts: qcom: kaanapali-mtp: Enable modem Jingyi Wang
2025-09-25  2:10   ` Dmitry Baryshkov
2025-09-29  3:28     ` Jingyi Wang
2025-09-25 14:06   ` Bjorn Andersson
2025-09-29  3:29     ` Jingyi Wang
2025-09-25  0:17 ` [PATCH 16/20] arm64: dts: qcom: kaanapali: Add QRD board Jingyi Wang
2025-09-25  2:15   ` Dmitry Baryshkov
2025-09-29  3:29     ` Jingyi Wang
2025-09-25  0:17 ` [PATCH 17/20] arm64: dts: qcom: kaanapali: Add support for audio Jingyi Wang
2025-09-25 12:30   ` Konrad Dybcio
2025-09-25  0:17 ` [PATCH 18/20] arm64: dts: qcom: kaanapali-mtp: Add audio support (WSA8845, WCD9395, DMIC) Jingyi Wang
2025-09-25 12:30   ` Konrad Dybcio
2025-09-25 13:26   ` Krzysztof Kozlowski
2025-09-30 12:06     ` Prasad Kumpatla
2025-10-06  8:48       ` Krzysztof Kozlowski
2025-10-08 10:20         ` Konrad Dybcio
2025-10-08 10:51           ` Krzysztof Kozlowski
2025-10-08 11:30             ` Konrad Dybcio
2025-10-08 23:50               ` Krzysztof Kozlowski
2025-10-27  9:39                 ` Konrad Dybcio
2025-09-25  0:17 ` [PATCH 19/20] arm64: dts: qcom: kaanapali: Add support for camss Jingyi Wang
2025-09-25  0:17 ` [PATCH 20/20] arm64: dts: qcom: kaanapali: Add iris video node Jingyi Wang
2025-10-07  2:17   ` Krzysztof Kozlowski
2025-10-08  8:30   ` Konrad Dybcio
2025-09-25 14:12 ` [PATCH 00/20] arm64: dts: qcom: Introduce Kaanapali platform device tree Rob Herring (Arm)
2025-09-25 16:51   ` Dmitry Baryshkov
2025-09-30 17:48 ` Alexey Klimov
2025-10-03  9:09   ` Prasad Kumpatla
2025-10-03 16:35     ` Alexey Klimov
2025-10-14  6:09       ` Jingyi Wang
2025-12-02 18:21 ` Pavel Machek
2025-12-02 18:33   ` Konrad Dybcio
2025-12-02 20:56     ` Pavel Machek
2025-12-03 10:34       ` Konrad Dybcio
2025-12-03 16:17         ` Pavel Machek
2025-12-03 17:31   ` Krzysztof Kozlowski
2025-12-03 18:10     ` Pavel Machek
2025-12-03 18:40       ` Krzysztof Kozlowski
2025-12-03 18:41         ` Krzysztof Kozlowski
2025-12-04  9:09           ` Pavel Machek
2025-12-04 10:41             ` Krzysztof Kozlowski
2025-12-04 11:42               ` Pavel Machek
2025-12-04 12:10                 ` Krzysztof Kozlowski
2025-12-04 12:26                   ` Pavel Machek
2025-12-04  9:14         ` Pavel Machek
2025-12-04 10:42           ` Krzysztof Kozlowski
2025-12-04 11:44             ` Pavel Machek
2025-12-04 12:07               ` Krzysztof Kozlowski
2025-12-04  2:41   ` Jingyi Wang
2025-12-04  8:56     ` Pavel Machek
2025-12-04  9:01       ` Krzysztof Kozlowski
2025-12-04  9:06         ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJKOXPetzYdOvYkzeWmm9pVM1MwJhng4JLn2jsoAuey4jtfrqQ@mail.gmail.com \
    --to=krzk@kernel.org \
    --cc=aiqun.yu@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jingyi.wang@oss.qualcomm.com \
    --cc=jishnu.prakash@oss.qualcomm.com \
    --cc=kamal.wadhwa@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=tingwei.zhang@oss.qualcomm.com \
    --cc=trilok.soni@oss.qualcomm.com \
    --cc=yijie.yang@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).