From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH 8/8] ASoC: samsung,tm2-audio DT binding documentation update Date: Mon, 12 Feb 2018 10:19:27 +0100 Message-ID: References: <20180205154403.13520-1-s.nawrocki@samsung.com> <20180205154403.13520-9-s.nawrocki@samsung.com> <67a9f473-0eba-b3d0-ae92-5602658b6958@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <67a9f473-0eba-b3d0-ae92-5602658b6958-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sylwester Nawrocki Cc: broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jcsing.lee-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, sbkim73-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, =?UTF-8?B?QmFydMWCb21pZWogxbtvxYJuaWVya2lld2ljeg==?= , Marek Szyprowski List-Id: devicetree@vger.kernel.org On Wed, Feb 7, 2018 at 5:31 PM, Sylwester Nawrocki wrote: > On 02/06/2018 02:05 PM, Krzysztof Kozlowski wrote: >> On Mon, Feb 5, 2018 at 4:44 PM, Sylwester Nawrocki >> wrote: >>> This patch documents additional entries of the audio-codec and >>> i2s-controller properties required for the HDMI audio support. >>> >>> Signed-off-by: Sylwester Nawrocki >>> --- >>> .../devicetree/bindings/sound/samsung,tm2-audio.txt | 14 +++++++++----- >>> 1 file changed, 9 insertions(+), 5 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/sound/samsung,tm2-audio.txt b/Documentation/devicetree/bindings/sound/samsung,tm2-audio.txt >>> index 94442e5673b3..f5ccc12ddc00 100644 >>> --- a/Documentation/devicetree/bindings/sound/samsung,tm2-audio.txt >>> +++ b/Documentation/devicetree/bindings/sound/samsung,tm2-audio.txt >>> @@ -4,9 +4,13 @@ Required properties: >>> >>> - compatible : "samsung,tm2-audio" >>> - model : the user-visible name of this sound complex >>> - - audio-codec : the phandle of the wm5110 audio codec node, >>> - as described in ../mfd/arizona.txt >>> - - i2s-controller : the phandle of the I2S controller >>> + - audio-codec : the first entry should be phandle of the wm5110 audio >>> + codec node, as described in ../mfd/arizona.txt; >>> + the second entry should be phandle of the HDMI >> >> AFAIU, this property is still optional so the wording should be >> different. Maybe just add "optional properties" paragraph? > > I'd like to keep the second entries required in the documentation, > and the driver would still be handling the case with just single > entries. I understand. Acked-by: Krzysztof Kozlowski Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html