From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
dianders@chromium.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] arm: dts: Fix audio card detection on peach boards
Date: Tue, 13 Oct 2015 08:49:27 +0900 [thread overview]
Message-ID: <CAJKOXPf8ZoHsP16fEWaRDMxd_7HRjzupOWOgp8ng2RjsL_BBuA@mail.gmail.com> (raw)
In-Reply-To: <561C0589.7010103@kernel.org>
2015-10-13 4:10 GMT+09:00 Kukjin Kim <kgene@kernel.org>:
> On 10/12/15 22:04, Krzysztof Kozlowski wrote:
>> W dniu 12.10.2015 o 21:37, Alim Akhtar pisze:
>>> Since commit 2fad972d45c4 ("ARM: dts: Add mclk entry for Peach boards"),
>>> sound card detection is broken on peach boards and gives below errors:
>>>
>>> [ 3.630457] max98090 7-0010: MAX98091 REVID=0x51
>>> [ 3.634233] max98090 7-0010: use default 2.8v micbias
>>> [ 3.640985] snow-audio sound: HiFi <-> 3830000.i2s mapping ok
>>> [ 3.645307] max98090 7-0010: Invalid master clock frequency
>>> [ 3.650824] snow-audio sound: ASoC: Peach-Pi-I2S-MAX98091 late_probe() failed: -22
>>> [ 3.658914] snow-audio sound: snd_soc_register_card failed (-22)
>>> [ 3.664366] snow-audio: probe of sound failed with error -22
>>>
>>> This patch adds missing assigned-clocks and assigned-clock-parents for
>>> pmu_system_controller node which is used as "mclk" for audio codec.
>>>
>>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
>>> Fixes: 2fad972d45c4 ("ARM: dts: Add mclk entry for Peach boards")
>>> Cc: <stable@vger.kernel.org>
>>> ---
>>> Changes since v1:
>>> Addressed Krzysztof's review comments.
>>
>> Looks good, thanks!
>>
>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>
> Applied, thanks.
I see you pulled that one and of_node_put() fix into fixes. Thanks!
Can you apply also Sudip's fix for thermal (acked by Lukasz)? I have
it my try but since you applied these two already it does not have
sense any more.
Best regards,
Krzysztof
next prev parent reply other threads:[~2015-10-12 23:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 12:37 [PATCH v2] arm: dts: Fix audio card detection on peach boards Alim Akhtar
2015-10-12 13:04 ` Krzysztof Kozlowski
2015-10-12 19:10 ` Kukjin Kim
2015-10-12 23:49 ` Krzysztof Kozlowski [this message]
[not found] ` <1444653438-6532-1-git-send-email-alim.akhtar-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-11-30 14:01 ` Javier Martinez Canillas
2015-11-30 16:59 ` Alim Akhtar
2015-11-30 18:24 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJKOXPf8ZoHsP16fEWaRDMxd_7HRjzupOWOgp8ng2RjsL_BBuA@mail.gmail.com \
--to=k.kozlowski@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).