From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Paweł Chmiel" <pawel.mikolaj.chmiel@gmail.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
airlied@linux.ie, Seung Woo Kim <sw0312.kim@samsung.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
robh+dt@kernel.org, kyungmin.park@samsung.com, kgene@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] dt-bindings: gpu: samsung-rotator: Document s5pv210 support
Date: Wed, 19 Dec 2018 17:22:51 +0100 [thread overview]
Message-ID: <CAJKOXPfHHNUzQZu62btspC+6SwgoGPdAzusfSixXM7U9u3QP7A@mail.gmail.com> (raw)
In-Reply-To: <20181219155704.15264-3-pawel.mikolaj.chmiel@gmail.com>
On Wed, 19 Dec 2018 at 17:04, Paweł Chmiel
<pawel.mikolaj.chmiel@gmail.com> wrote:
>
> This commit documents new compatible for s5pv210 soc,
> which will be also supported by this driver.
>
> Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com>
> ---
> Documentation/devicetree/bindings/gpu/samsung-rotator.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/gpu/samsung-rotator.txt b/Documentation/devicetree/bindings/gpu/samsung-rotator.txt
> index 82cd1ed0be93..78658dec6941 100644
> --- a/Documentation/devicetree/bindings/gpu/samsung-rotator.txt
> +++ b/Documentation/devicetree/bindings/gpu/samsung-rotator.txt
> @@ -5,6 +5,7 @@ Required properties:
> (a) "samsung,exynos4210-rotator" for Rotator IP in Exynos4210
> (b) "samsung,exynos4212-rotator" for Rotator IP in Exynos4212/4412
> (c) "samsung,exynos5250-rotator" for Rotator IP in Exynos5250
> + (d) "samsung,s5pv210-rotator" for Rotator IP in S5PV210
How about putting it at beginning as the oldest chipset? This would
require reordering the list so maybe let's remove the a/b/c list
enumerations? They are kind of useless.
Best regards,
Krzysztof
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-12-19 16:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-19 15:57 [PATCH 0/3] drm/exynos: rotator: Add support for s5pv210 Paweł Chmiel
2018-12-19 15:57 ` [PATCH 1/3] " Paweł Chmiel
2019-01-09 3:59 ` Inki Dae
2018-12-19 15:57 ` [PATCH 2/3] dt-bindings: gpu: samsung-rotator: Document s5pv210 support Paweł Chmiel
2018-12-19 16:22 ` Krzysztof Kozlowski [this message]
2018-12-27 11:57 ` Paweł Chmiel
2018-12-19 15:57 ` [PATCH 3/3] ARM: dts: s5pv210: Add node for exynos-rotator Paweł Chmiel
2018-12-19 16:24 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJKOXPfHHNUzQZu62btspC+6SwgoGPdAzusfSixXM7U9u3QP7A@mail.gmail.com \
--to=krzk@kernel.org \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kgene@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.mikolaj.chmiel@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).