From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1E50C433DB for ; Mon, 22 Feb 2021 19:20:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7B82B61481 for ; Mon, 22 Feb 2021 19:20:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233079AbhBVTUW (ORCPT ); Mon, 22 Feb 2021 14:20:22 -0500 Received: from mail.kernel.org ([198.145.29.99]:51018 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233054AbhBVTQz (ORCPT ); Mon, 22 Feb 2021 14:16:55 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id EF64165118; Mon, 22 Feb 2021 18:40:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614019250; bh=FGxvnhEiZdtEIFwNlh9p2vw8zFYiWQ8F2/ji5QGybDk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=o17vjMIXFmg1nNg4qhQE+0IC/W+SF9BzYFFEUmvUwgP0zNXSRmKykCORaHVF9p2ID Y0cvnPSFS2W10mswB/fkK//RZA1SXmksgPZumWggr0p47PUk7RwSngMwxYB+6hWoN1 pXF/lek8rfwsuC9F3mtYpjxPqGMfx/Z0rB97SyxTtWBpsDn9YrX/xLgnYwg1v1yia9 dBKNCYWZoe44D2lY2CTOZC/ttQxt3Gp57E35elGco9kSrSrN7Gn6jNCL7mD4P7K4oB F8xef9dQQH+ldpSJsimkTvn71Az6RI6VKziMhFMY2bqAQ0nOMDBZP5hbExskm+f08h D+HUzf2CDuFvg== Received: by mail-ej1-f48.google.com with SMTP id r17so4618316ejy.13; Mon, 22 Feb 2021 10:40:49 -0800 (PST) X-Gm-Message-State: AOAM5302cc43mlK/DVgTIqm/iIWxlj7L560dnLLbgKW/WQL91twsI/KA 0emxo2htF+drVSejNFJPJcF5W83eflnHtfATMeY= X-Google-Smtp-Source: ABdhPJzaXVC2DvM4oFpMDq0yZw6KQI4Xsck0Cs0vUHPzVa8d1nIi+XpW2/JXhZmYymgo3rcaQCLk2m5Ys9psM7Cohi0= X-Received: by 2002:a17:906:1c4f:: with SMTP id l15mr11249440ejg.148.1614019248445; Mon, 22 Feb 2021 10:40:48 -0800 (PST) MIME-Version: 1.0 References: <20210217161052.877877-1-adrien.grassein@gmail.com> <20210217161052.877877-2-adrien.grassein@gmail.com> <20210219131825.niiftfm5r32qc6m3@kozik-lap> <20210220191914.pir3ep3utz6uwyrb@kozik-lap> In-Reply-To: From: Krzysztof Kozlowski Date: Mon, 22 Feb 2021 19:40:35 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/8] arm64: dts: imx8mm-nitrogen-r2: add wifi/bt chip To: Adrien Grassein Cc: Rob Herring , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , dl-linux-imx , catalin.marinas@arm.com, will@kernel.org, DTML , linux-arm-kernel@lists.infradead.org, linux-kernel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 22 Feb 2021 at 00:47, Adrien Grassein w= rote: > > Le sam. 20 f=C3=A9vr. 2021 =C3=A0 20:19, Krzysztof Kozlowski a =C3=A9crit : > > > > On Fri, Feb 19, 2021 at 03:03:55PM +0100, Adrien Grassein wrote: > > > Le ven. 19 f=C3=A9vr. 2021 =C3=A0 14:18, Krzysztof Kozlowski a =C3=A9crit : > > > > > > > > On Wed, Feb 17, 2021 at 05:10:45PM +0100, Adrien Grassein wrote: > > > > > Add usdhc3 description which corresponds to the wifi/bt chip > > > > > > > > > > Signed-off-by: Adrien Grassein > > > > > --- > > > > > .../boot/dts/freescale/imx8mm-nitrogen-r2.dts | 31 +++++++++++++= ++++++ > > > > > 1 file changed, 31 insertions(+) > > > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts= b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts > > > > > index c0c384d76147..212dc9e5e85d 100644 > > > > > --- a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts > > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts > > > > > @@ -9,6 +9,17 @@ > > > > > / { > > > > > model =3D "Boundary Devices i.MX8MMini Nitrogen8MM Rev2"; > > > > > compatible =3D "boundary,imx8mm-nitrogen8mm", "fsl,imx8mm"; > > > > > + > > > > > + reg_wlan_vmmc: regulator-wlan-vmmc { > > > > > + compatible =3D "regulator-fixed"; > > > > > + pinctrl-names =3D "default"; > > > > > + pinctrl-0 =3D <&pinctrl_reg_wlan_vmmc>; > > > > > + regulator-name =3D "reg_wlan_vmmc"; > > > > > + regulator-min-microvolt =3D <3300000>; > > > > > + regulator-max-microvolt =3D <3300000>; > > > > > + gpio =3D <&gpio3 20 GPIO_ACTIVE_HIGH>; > > > > > + enable-active-high; > > > > > + }; > > > > > }; > > > > > > > > > > &A53_0 { > > > > > @@ -206,6 +217,20 @@ &usdhc2 { > > > > > status =3D "okay"; > > > > > }; > > > > > > > > > > +/* wlan */ > > > > > +&usdhc3 { > > > > > + bus-width =3D <4>; > > > > > + sdhci-caps-mask =3D <0x2 0x0>; > > > > > + non-removable; > > > > > + pinctrl-names =3D "default", "state_100mhz", "state_200mhz"= ; > > > > > + pinctrl-0 =3D <&pinctrl_usdhc3>; > > > > > + pinctrl-1 =3D <&pinctrl_usdhc3_100mhz>; > > > > > + pinctrl-2 =3D <&pinctrl_usdhc3_200mhz>; > > > > > + vmmc-supply =3D <®_wlan_vmmc>; > > > > > + vqmmc-1-8-v; > > > > > > > > There is no such property in the bindings. > > > > > > > > > > Sorry, I copied a property from the FSL kernel. > > > I will fix this with a "fixed-regulator". > > > > I would assume this goes from PMIC, so check your schematics. There is > > little point in adding a fixed regulator which is non-controllable. > > No, the 1.8V is issued directly from the alimentation stage. > So we can't control it. > > > I think bindings don't require it. > After reading some code, I can say that vqmmc is not mandatory but it > helped to find out > the caps of the mmc host. In this case, we only support 1.8V on vqmmc. > It avoids driver to guess it (and avoid bad behaviour on any future chang= e). If the supply (hardware) is really 1.8 V then indeed your approach is good. So let's keep that one. Best regards, Krzysztof