From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: broonie@kernel.org, lgirdwood@gmail.com,
alsa-devel@alsa-project.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
jcsing.lee@samsung.com, sbkim73@samsung.com,
linux-kernel@vger.kernel.org,
"Bartłomiej Żołnierkiewicz" <b.zolnierkie@samsung.com>,
"Marek Szyprowski" <m.szyprowski@samsung.com>
Subject: Re: [PATCH v2 3/7] ASoC: samsung: i2s: Prevent external abort on exynos5433 I2S1 access
Date: Tue, 13 Feb 2018 08:25:59 +0100 [thread overview]
Message-ID: <CAJKOXPfktrQGJsHECCwJxw37eD_dpXYHXEXsA1W_sOFCwB5MPg@mail.gmail.com> (raw)
In-Reply-To: <20180212161538.22669-4-s.nawrocki@samsung.com>
On Mon, Feb 12, 2018 at 5:15 PM, Sylwester Nawrocki
<s.nawrocki@samsung.com> wrote:
> It seems both PCLK_I2S1 and SCLK_I2S1 clocks need to be enabled before
> I2S1 control registers can be accessed on exynos5433. If SCLK clock
> is disabled an exception is triggered. To fix this parent clock of
> the RCLK_SRC clock is assigned to pri_dai->op_clk so required gate
> clock is handled by the runtime PM ops.
>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> ---
> Changes since v1:
> - removed stray whitespace change.
> ---
> sound/soc/samsung/i2s.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2018-02-13 7:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180212161554epcas2p26c19860d14006b0e1501699dc50d3f2f@epcas2p2.samsung.com>
2018-02-12 16:15 ` [PATCH v2 0/7] ASoC: samsung: Add HDMI sound support for tm2 board Sylwester Nawrocki
[not found] ` <CGME20180212161636epcas2p25f894b22e938ea8f3371196e7e90c169@epcas2p2.samsung.com>
2018-02-12 16:15 ` [PATCH v2 1/7] ASoC: samsung: i2s: Update clock-output-names property documentation Sylwester Nawrocki
2018-02-14 13:29 ` Applied "ASoC: samsung: i2s: Update clock-output-names property documentation" to the asoc tree Mark Brown
[not found] ` <CGME20180212161641epcas1p2418c2323e5eb99a37a89b42c246f23dd@epcas1p2.samsung.com>
[not found] ` <20180212161538.22669-1-s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2018-02-12 16:15 ` [PATCH v2 2/7] ASoC: samsung: i2s: Ensure names of supplied clocks are unique Sylwester Nawrocki
2018-02-13 7:25 ` Krzysztof Kozlowski
2018-02-14 13:29 ` Applied "ASoC: samsung: i2s: Ensure names of supplied clocks are unique" to the asoc tree Mark Brown
2018-02-12 16:15 ` [PATCH v2 6/7] ASoC: samsung: Add support for HDMI audio on TM2 board Sylwester Nawrocki
2018-02-13 7:27 ` Krzysztof Kozlowski
2018-02-14 13:29 ` Applied "ASoC: samsung: Add support for HDMI audio on TM2 board" to the asoc tree Mark Brown
[not found] ` <CGME20180212161646epcas1p2dabca4c8d98d3e66b7a78133d926bccb@epcas1p2.samsung.com>
2018-02-12 16:15 ` [PATCH v2 3/7] ASoC: samsung: i2s: Prevent external abort on exynos5433 I2S1 access Sylwester Nawrocki
2018-02-13 7:25 ` Krzysztof Kozlowski [this message]
2018-02-14 13:29 ` Applied "ASoC: samsung: i2s: Prevent external abort on exynos5433 I2S1 access" to the asoc tree Mark Brown
[not found] ` <CGME20180212161651epcas1p4a8d293d6b9e2af10037159c717de1be2@epcas1p4.samsung.com>
2018-02-12 16:15 ` [PATCH v2 4/7] ASoC: samsung: i2s: Define the parameters list for SAMSUNG_I2S_OPCLK Sylwester Nawrocki
[not found] ` <CGME20180212161700epcas2p3f810196ade27315587602b16707755c6@epcas2p3.samsung.com>
2018-02-12 16:15 ` [PATCH v2 5/7] ASoC: samsung,tm2-audio DT binding documentation update Sylwester Nawrocki
[not found] ` <CGME20180212161711epcas1p2285c5a778cf12ab00211063b1b4a0fc3@epcas1p2.samsung.com>
2018-02-12 16:15 ` [PATCH v2 7/7] ASoC: samsung: Add missing #sound-dai-cells property documentation Sylwester Nawrocki
[not found] ` <20180212161538.22669-8-s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2018-02-13 7:27 ` Krzysztof Kozlowski
2018-02-14 13:28 ` Applied "ASoC: samsung: Add missing #sound-dai-cells property documentation" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJKOXPfktrQGJsHECCwJxw37eD_dpXYHXEXsA1W_sOFCwB5MPg@mail.gmail.com \
--to=krzk@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jcsing.lee@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).