From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v2 3/7] ASoC: samsung: i2s: Prevent external abort on exynos5433 I2S1 access Date: Tue, 13 Feb 2018 08:25:59 +0100 Message-ID: References: <20180212161538.22669-1-s.nawrocki@samsung.com> <20180212161538.22669-4-s.nawrocki@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20180212161538.22669-4-s.nawrocki@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org To: Sylwester Nawrocki Cc: broonie@kernel.org, lgirdwood@gmail.com, alsa-devel@alsa-project.org, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, jcsing.lee@samsung.com, sbkim73@samsung.com, linux-kernel@vger.kernel.org, =?UTF-8?B?QmFydMWCb21pZWogxbtvxYJuaWVya2lld2ljeg==?= , Marek Szyprowski List-Id: devicetree@vger.kernel.org On Mon, Feb 12, 2018 at 5:15 PM, Sylwester Nawrocki wrote: > It seems both PCLK_I2S1 and SCLK_I2S1 clocks need to be enabled before > I2S1 control registers can be accessed on exynos5433. If SCLK clock > is disabled an exception is triggered. To fix this parent clock of > the RCLK_SRC clock is assigned to pri_dai->op_clk so required gate > clock is handled by the runtime PM ops. > > Signed-off-by: Sylwester Nawrocki > --- > Changes since v1: > - removed stray whitespace change. > --- > sound/soc/samsung/i2s.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) Acked-by: Krzysztof Kozlowski Best regards, Krzysztof