From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D05CDC388F7 for ; Thu, 5 Nov 2020 12:25:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6FFB72078E for ; Thu, 5 Nov 2020 12:25:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604579110; bh=mQn6eQC8BgHY7sVHx/l8lzOgl2uWd1caiUoW+FfNyd8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=vY/V7MaG4cyhq6r3SUX6W7KBnpZ5Bnv0DUoVDiCpy32vxXMGqi7t8AO2TU39L5IdR A4A8o0w2wqEKclznN4yIhwaJXDjgVd+BOdy85G8REwikeN505ANddQVXtWzLSWwxyA EDDBr5Jw2whCRYPyKwALCGEf6uUG7QAUhVxFzglk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727275AbgKEMZJ (ORCPT ); Thu, 5 Nov 2020 07:25:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:35604 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725468AbgKEMZJ (ORCPT ); Thu, 5 Nov 2020 07:25:09 -0500 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 38F162078E; Thu, 5 Nov 2020 12:25:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604579108; bh=mQn6eQC8BgHY7sVHx/l8lzOgl2uWd1caiUoW+FfNyd8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Xdv3zZVRDbS/oefaYlHx0GlF+5Tza70M6VZEhQBHrBgO9szMGieEHZU/hxRV4JqyN 6UoaLgsyH0L68tYQzzPi8etwz09xZq5W3srfXAgy2a/rqmJa+YVzjOtjPgiTrBSIkd dYSQqFSQ5834EbvsGeuRbZ7wl1kBqFmef7NQoK+o= Received: by mail-ej1-f50.google.com with SMTP id o9so2351526ejg.1; Thu, 05 Nov 2020 04:25:08 -0800 (PST) X-Gm-Message-State: AOAM531iu9QkViHzYmzIA0XaC3mB9heolbEEnuSOsCaC7mEhRN4fs2Gt aeeNfd3yKOnb4excC1d0C3HJC6HTJqNqtgtghmI= X-Google-Smtp-Source: ABdhPJxtLqq7R2+xslnKnuHlzyKI3dzkhbUoBKlME67gbPsBxdBuzfnBLveHWCaKlx1rJ771h4Hd1tVYM36lFOUIBNw= X-Received: by 2002:a17:906:491a:: with SMTP id b26mr1971570ejq.385.1604579106683; Thu, 05 Nov 2020 04:25:06 -0800 (PST) MIME-Version: 1.0 References: <20201105072629.24175-1-alice.guo@nxp.com> <20201105082543.GA17569@kozik-lap> In-Reply-To: From: Krzysztof Kozlowski Date: Thu, 5 Nov 2020 13:24:55 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [EXT] Re: [PATCH v2 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID To: Alice Guo Cc: "robh+dt@kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , dl-linux-imx , Peng Fan , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, 5 Nov 2020 at 13:19, Alice Guo wrote: > > > > > -----Original Message----- > > From: Krzysztof Kozlowski > > Sent: 2020=E5=B9=B411=E6=9C=885=E6=97=A5 16:26 > > To: Alice Guo > > Cc: robh+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de; > > dl-linux-imx ; Peng Fan ; > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > > linux-arm-kernel@lists.infradead.org > > Subject: [EXT] Re: [PATCH v2 1/4] dt-bindings: soc: imx8m: add DT Bindi= ng doc > > for soc unique ID > > > > Caution: EXT Email > > > > On Thu, Nov 05, 2020 at 03:26:26PM +0800, Alice Guo wrote: > > > Add DT Binding doc for the Unique ID of i.MX 8M series. > > > > > > Signed-off-by: Alice Guo > > > --- > > > .../devicetree/bindings/arm/fsl.yaml | 33 > > +++++++++++++++++++ > > > 1 file changed, 33 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml > > b/Documentation/devicetree/bindings/arm/fsl.yaml > > > index e4db0f9ed664..0419f078502b 100644 > > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > > @@ -901,6 +901,39 @@ properties: > > > - fsl,s32v234-evb # S32V234-EVB2 Customer > > Evaluation Board > > > - const: fsl,s32v234 > > > > > > + soc: > > > + description: > > > + i.MX8M Family SoC must provide a soc node in the root of the d= evice > > tree, > > > + representing the System-on-Chip since these test chips are rat= her > > complex. > > > + type: object > > > + properties: > > > + compatible: > > > + oneOf: > > > + - items: > > > + - const: fsl,imx8mm-soc > > > + - const: simple-bus > > > + - items: > > > + - const: fsl,imx8mn-soc > > > + - const: simple-bus > > > + - items: > > > + - const: fsl,imx8mp-soc > > > + - const: simple-bus > > > + - items: > > > + - const: fsl,imx8mq-soc > > > + - const: simple-bus > > > + > > > + nvmem-cells: > > > + maxItems: 1 > > > + description: Phandle to the SOC Unique ID provided by a nvme= m > > node > > > + > > > + nvmem-cells-names: > > > + const: soc_unique_id > > > + > > > + required: > > > + - compatible > > > + - nvmem-cells > > > + - nvmem-cell-names > > > + > > > > Did you actually test it? I see multiple errors with this patch. > > fsl-ls1012a-frdm.dt.yaml: /: soc:compatible: ['simple-bus'] is not vali= d under any > > of the given schemas > > > > Best regards, > > Krzysztof > > > [Alice Guo] Sorry. I did not see errors what you said. Can you tell me ho= w did you test it? It was a regular DT check, nothing unusual (make dtbs_check). Best regards, Krzysztof