[PATCH v4] mfd: max77693: Add muic of_compatible in mfd_cell

[PATCH v4] mfd: max77693: Add muic of_compatible in mfd_cell

[Maciej Purski]

This patch adds muic of_compatible in order to use the muic device
driver in device tree.

Signed-off-by: Maciej Purski <m.purski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
v2:
- added muic to documentation
v3:
- removed duplication
v4:
- fixed commit message

 Documentation/devicetree/bindings/mfd/max77693.txt | 6 ++++++
 drivers/mfd/max77693.c                             | 5 ++++-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mfd/max77693.txt b/Documentation/devicetree/bindings/mfd/max77693.txt
index 6a1ae3a..e675497 100644
--- a/Documentation/devicetree/bindings/mfd/max77693.txt
+++ b/Documentation/devicetree/bindings/mfd/max77693.txt
@@ -127,6 +127,12 @@ Required properties for the LED child node:
 Optional properties for the LED child node:
 - label : see Documentation/devicetree/bindings/leds/common.txt
 
+Optional nodes:
+- max77693-muic :
+	Node used only by extcon consumers.
+	Required properties:
+		- compatible : "maxim,max77693-muic"
+
 Example:
 #include <dt-bindings/leds/common.h>
 
diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
index 662ae0d..1c05ea0 100644
--- a/drivers/mfd/max77693.c
+++ b/drivers/mfd/max77693.c
@@ -48,7 +48,10 @@ static const struct mfd_cell max77693_devs[] = {
 		.name = "max77693-charger",
 		.of_compatible = "maxim,max77693-charger",
 	},
-	{ .name = "max77693-muic", },
+	{
+		.name = "max77693-muic",
+		.of_compatible = "maxim,max77693-muic",
+	},
 	{
 		.name = "max77693-haptic",
 		.of_compatible = "maxim,max77693-haptic",
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4] mfd: max77693: Add muic of_compatible in mfd_cell

[Chanwoo Choi]

Hi Maciej,

Why do you miss my reviewed-by tag?
If there is no huge changes, you need to keep the previous review tag.

Reviewed-by: Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>


On 2017년 08월 23일 15:30, Maciej Purski wrote:
> This patch adds muic of_compatible in order to use the muic device
> driver in device tree.
> 
> Signed-off-by: Maciej Purski <m.purski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
> v2:
> - added muic to documentation
> v3:
> - removed duplication
> v4:
> - fixed commit message
> 
>  Documentation/devicetree/bindings/mfd/max77693.txt | 6 ++++++
>  drivers/mfd/max77693.c                             | 5 ++++-
>  2 files changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/max77693.txt b/Documentation/devicetree/bindings/mfd/max77693.txt
> index 6a1ae3a..e675497 100644
> --- a/Documentation/devicetree/bindings/mfd/max77693.txt
> +++ b/Documentation/devicetree/bindings/mfd/max77693.txt
> @@ -127,6 +127,12 @@ Required properties for the LED child node:
>  Optional properties for the LED child node:
>  - label : see Documentation/devicetree/bindings/leds/common.txt
>  
> +Optional nodes:
> +- max77693-muic :
> +	Node used only by extcon consumers.
> +	Required properties:
> +		- compatible : "maxim,max77693-muic"
> +
>  Example:
>  #include <dt-bindings/leds/common.h>
>  
> diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
> index 662ae0d..1c05ea0 100644
> --- a/drivers/mfd/max77693.c
> +++ b/drivers/mfd/max77693.c
> @@ -48,7 +48,10 @@ static const struct mfd_cell max77693_devs[] = {
>  		.name = "max77693-charger",
>  		.of_compatible = "maxim,max77693-charger",
>  	},
> -	{ .name = "max77693-muic", },
> +	{
> +		.name = "max77693-muic",
> +		.of_compatible = "maxim,max77693-muic",
> +	},
>  	{
>  		.name = "max77693-haptic",
>  		.of_compatible = "maxim,max77693-haptic",
> 

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4] mfd: max77693: Add muic of_compatible in mfd_cell

[Krzysztof Kozlowski]

On Wed, Aug 23, 2017 at 8:34 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
> Hi Maciej,
>
> Why do you miss my reviewed-by tag?
> If there is no huge changes, you need to keep the previous review tag.
>
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

Same here:
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof

Re: [PATCH v4] mfd: max77693: Add muic of_compatible in mfd_cell

[Rob Herring]

On Wed, Aug 23, 2017 at 08:30:12AM +0200, Maciej Purski wrote:
> This patch adds muic of_compatible in order to use the muic device
> driver in device tree.
> 
> Signed-off-by: Maciej Purski <m.purski@samsung.com>
> ---
> v2:
> - added muic to documentation
> v3:
> - removed duplication
> v4:
> - fixed commit message
> 
>  Documentation/devicetree/bindings/mfd/max77693.txt | 6 ++++++
>  drivers/mfd/max77693.c                             | 5 ++++-
>  2 files changed, 10 insertions(+), 1 deletion(-)

Acked-by: Rob Herring <robh@kernel.org>

Re: [PATCH v4] mfd: max77693: Add muic of_compatible in mfd_cell

[Lee Jones]

On Wed, 23 Aug 2017, Maciej Purski wrote:

> This patch adds muic of_compatible in order to use the muic device
> driver in device tree.
> 
> Signed-off-by: Maciej Purski <m.purski@samsung.com>
> ---
> v2:
> - added muic to documentation
> v3:
> - removed duplication
> v4:
> - fixed commit message
> 
>  Documentation/devicetree/bindings/mfd/max77693.txt | 6 ++++++
>  drivers/mfd/max77693.c                             | 5 ++++-
>  2 files changed, 10 insertions(+), 1 deletion(-)

For my own reference:
  Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>

Please collect the Acks you have and submit a [RESEND].

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog