From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3561AC61DA4 for ; Thu, 16 Feb 2023 09:27:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229923AbjBPJ1s (ORCPT ); Thu, 16 Feb 2023 04:27:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229932AbjBPJ1r (ORCPT ); Thu, 16 Feb 2023 04:27:47 -0500 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F277142BE2 for ; Thu, 16 Feb 2023 01:27:45 -0800 (PST) Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 8FC1C3F585 for ; Thu, 16 Feb 2023 09:27:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1676539661; bh=YtSJffCXpHu3ueJ8PsUTFVvEARiCiygu2497e6lu3sk=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=CeUzaLgpI0J1mAKHraUXg8X+aNq2zKtRd126ADJ4cV+L9dS2SMuwOFwkbopCM83Hc XOoSH96u+FsPu+VIekHQtQgLECYYUBzOnKG35N8ag6okHpSHatTGNMkJRIBwJ8qetM 2tnLY2fN8M/QKX+8KrUHakvvf/Yhh6NAd1F+t8sWssDzj5sd4rmVrgHlswAf7ZvuQi 6D+iNVvJdYMOb51abfGCy+n4vovlWPvnZfPGnTGnQETchHLSSOH+21toXkoMy+ioTR txVZQTPR9RlW896CqUFXcwvOQ8zJsrenb9YUAbksSHlR5e0vS4WZKO3zT96R2WlEOu SQ/ePWTt7H7qw== Received: by mail-qv1-f69.google.com with SMTP id gu10-20020a056214260a00b0056c2005684aso759503qvb.23 for ; Thu, 16 Feb 2023 01:27:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1676539654; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YtSJffCXpHu3ueJ8PsUTFVvEARiCiygu2497e6lu3sk=; b=MvmTlX5eBJIxZXend973EitTTczDcwjPunYdGg5wWQgIZiIsTPq7r7ezntNybNNYCM UfjRWOKe9JU6+Nxr2sGpRCGGL7O4MeV4JLNA086f5m8aMPB0y3ZwBRV1HXOCk2/eH15m /JVMzZvh44QQ9cQjtweL1IZtZl1tNlu80UMy88cET12dE2xQ+5AqvzMwFvNKttS1w55l GM/CbDsyHqPef/RjzL3HW4qn89umZFY8QUKQFv/Yt67UnOFYL8JfyUiRSP41UuO9mcXD m6s4UXMSRTXfDznaV3yNzMoLOZePkvN7H39kuRNhTw0DR0KBA6zt1NUxUGGU9iBbdnlI qE0A== X-Gm-Message-State: AO0yUKW1u2Bg+8IU/rrKYLA6uhtkr8e7yH4jj429nzi9gS8rn0tn2+PY nhezqOB24yemKtupZl2JsZThb6W06g2Z7p/PMuC+3R3ya+rCDTi5O6mv3OR+eZJxJwTss/nN9uA O4JLERF/fLlOYnaPNnUE15ZAf5A9TJWewrbuJfKvDPrknfj7XOk3jskE= X-Received: by 2002:a0c:aa99:0:b0:56e:9a77:3d2c with SMTP id f25-20020a0caa99000000b0056e9a773d2cmr423870qvb.5.1676539654701; Thu, 16 Feb 2023 01:27:34 -0800 (PST) X-Google-Smtp-Source: AK7set+gOh5M+60vN2srtjtTI82UUYYfTQ40fizvaxdbVgr7R/vjEXOgtRRd+V8bdRCq8Uk/39SmMqfAZgINDo1mvAo= X-Received: by 2002:a0c:aa99:0:b0:56e:9a77:3d2c with SMTP id f25-20020a0caa99000000b0056e9a773d2cmr423864qvb.5.1676539654466; Thu, 16 Feb 2023 01:27:34 -0800 (PST) MIME-Version: 1.0 References: <20221220011247.35560-1-hal.feng@starfivetech.com> <20221220011247.35560-8-hal.feng@starfivetech.com> In-Reply-To: From: Emil Renner Berthing Date: Thu, 16 Feb 2023 10:27:17 +0100 Message-ID: Subject: Re: [PATCH v3 7/7] riscv: dts: starfive: Add StarFive JH7110 VisionFive 2 board device tree To: Hal Feng Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, Conor Dooley , Palmer Dabbelt , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Albert Ou , Ben Dooks , Daniel Lezcano , Thomas Gleixner , Marc Zyngier , Stephen Boyd , Michael Turquette , Philipp Zabel , Linus Walleij , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 15 Feb 2023 at 15:04, Hal Feng wrote: > > On 2/14/2023 5:53 PM, Emil Renner Berthing wrote: > > On Tue, 20 Dec 2022 at 02:12, Hal Feng wrote: > >> > >> From: Emil Renner Berthing > >> > >> Add a minimal device tree for StarFive JH7110 VisionFive 2 board > >> which has version A and version B. Support booting and basic > >> clock/reset/pinctrl/uart drivers. > >> > >> Signed-off-by: Emil Renner Berthing > >> Co-developed-by: Jianlong Huang > >> Signed-off-by: Jianlong Huang > >> Co-developed-by: Hal Feng > >> Signed-off-by: Hal Feng > >> --- > >> arch/riscv/boot/dts/starfive/Makefile | 1 + > >> .../jh7110-starfive-visionfive-2-va.dts | 13 ++ > >> .../jh7110-starfive-visionfive-2-vb.dts | 13 ++ > >> .../jh7110-starfive-visionfive-2.dtsi | 111 ++++++++++++++++++ > >> 4 files changed, 138 insertions(+) > >> create mode 100644 arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-va.dts > >> create mode 100644 arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-vb.dts > >> create mode 100644 arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi > >> > >> diff --git a/arch/riscv/boot/dts/starfive/Makefile b/arch/riscv/boot/dts/starfive/Makefile > >> index 0ea1bc15ab30..79e925a4a227 100644 > >> --- a/arch/riscv/boot/dts/starfive/Makefile > >> +++ b/arch/riscv/boot/dts/starfive/Makefile > >> @@ -1,2 +1,3 @@ > >> # SPDX-License-Identifier: GPL-2.0 > >> dtb-$(CONFIG_SOC_STARFIVE) += jh7100-beaglev-starlight.dtb > >> +dtb-$(CONFIG_SOC_STARFIVE) += jh7110-starfive-visionfive-2-va.dtb jh7110-starfive-visionfive-2-vb.dtb > >> diff --git a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-va.dts b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-va.dts > >> new file mode 100644 > >> index 000000000000..188d3fddbe88 > >> --- /dev/null > >> +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-va.dts > >> @@ -0,0 +1,13 @@ > >> +// SPDX-License-Identifier: GPL-2.0 OR MIT > >> +/* > >> + * Copyright (C) 2022 StarFive Technology Co., Ltd. > >> + * Copyright (C) 2022 Emil Renner Berthing > >> + */ > >> + > >> +/dts-v1/; > >> +#include "jh7110-starfive-visionfive-2.dtsi" > >> + > >> +/ { > >> + model = "StarFive VisionFive 2 VA"; > >> + compatible = "starfive,visionfive-2-va", "starfive,jh7110"; > >> +}; > >> diff --git a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-vb.dts b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-vb.dts > >> new file mode 100644 > >> index 000000000000..f75c10536f84 > >> --- /dev/null > >> +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-vb.dts > >> @@ -0,0 +1,13 @@ > >> +// SPDX-License-Identifier: GPL-2.0 OR MIT > >> +/* > >> + * Copyright (C) 2022 StarFive Technology Co., Ltd. > >> + * Copyright (C) 2022 Emil Renner Berthing > >> + */ > >> + > >> +/dts-v1/; > >> +#include "jh7110-starfive-visionfive-2.dtsi" > >> + > >> +/ { > >> + model = "StarFive VisionFive 2 VB"; > >> + compatible = "starfive,visionfive-2-vb", "starfive,jh7110"; > > > > Hi Hal, > > > > I just want to double check, is "VisionFive 2 VA" / "visoinfive-2-va" > > and "VisionFive 2 VB" / "visionfive-2-vb" really what you want? I > > still think having these names match what is printed on the silkscreen > > makes it a lot easier for everybody. Even your own releases calls the > > boards "v1.2A" and "v1.3B": > > https://github.com/starfive-tech/VisionFive2/releases/ > > > > So I'd suggest > > model = "StarFive VisionFive 2 v1.3B"; > > compatible = "starfive,visionfive-2-v1.3b", "starfive,jh7110"; > > > > I haven't seen these "VA" and "VB" anywhere else, so if you don't want > > the version numbers and can promise that there will be no incompatible > > future revisions of the boards then maybe just drop the "V". Eg. > > model = "StarFive VisionFive 2 B"; > > compatible = "starfive,visionfive-2-b", "starfive,jh7110"; > > The version A board has reached the end of life. As far as I know, the > version B board will not update also unless there are some important > requirements and StarFive decides to update. Furthermore, it's too late > to change the compatible as patch 1 was already accepted. Will it be > easier to read if I modify it as below? > > model = "StarFive VisionFive 2 vB"; > compatible = "starfive,visionfive-2-vb", "starfive,jh7110"; Oh, that's sad that the kernel will now end up calling the boards something that's used nowhere else, even by StarFive :/ But yeah, I guess vA and vB are a little easier to read. > Best regards, > Hal