From: Emil Renner Berthing <emil.renner.berthing@canonical.com>
To: Drew Fustini <dfustini@baylibre.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Jisheng Zhang <jszhang@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Guo Ren <guoren@kernel.org>, Fu Wei <wefu@redhat.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Conor Dooley <conor@kernel.org>
Cc: devicetree@vger.kernel.org, Han Gao <gaohan@iscas.ac.cn>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
Robert Nelson <robertcnelson@beagleboard.org>,
Jason Kridner <jkridner@beagleboard.org>,
Xi Ruoyao <xry111@xry111.site>,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v3 6/7] riscv: dts: thead: Enable BeagleV Ahead eMMC and microSD
Date: Tue, 24 Oct 2023 05:16:25 -0700 [thread overview]
Message-ID: <CAJM55Z-OBUsnybSLTxB8RHwsYuWhsMKVH3x8ana4=LeZ98Yv1Q@mail.gmail.com> (raw)
In-Reply-To: <20231023-th1520-mmc-v3-6-abc5e7491166@baylibre.com>
Drew Fustini wrote:
> Add mmc0 properties for the eMMC device and add mmc1 properties for
> the microSD slot. Set the frequency for the sdhci clock.
>
> Signed-off-by: Drew Fustini <dfustini@baylibre.com>
> ---
> arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts b/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts
> index 70e8042c8304..c4e748827889 100644
> --- a/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts
> +++ b/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts
> @@ -52,6 +52,10 @@ &uart_sclk {
> clock-frequency = <100000000>;
> };
>
> +&sdhci_clk {
> + clock-frequency = <198000000>;
> +};
> +
> &dmac0 {
> status = "okay";
> };
> @@ -59,3 +63,19 @@ &dmac0 {
> &uart0 {
> status = "okay";
> };
> +
> +&mmc0 {
> + bus-width = <8>;
> + max-frequency = <198000000>;
> + mmc-hs400-1_8v;
> + non-removable;
> + no-sdio;
> + no-sd;
> + status = "okay";
> +};
> +
> +&mmc1 {
> + max-frequency = <198000000>;
> + bus-width = <4>;
> + status = "okay";
> +};
Hi Drew,
For the StarFive device tree files we've agreed on sorting by / node, clock
references, and then other node references alphabetically. I'm not
insisting you should do the same, but it would be nice with some system to make
it clear where new node refences should go. Or maybe I'm just not seeing the
system you're already following.
/Emil
>
> --
> 2.34.1
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-10-24 12:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 21:07 [PATCH v3 0/7] RISC-V: Add MMC support for TH1520 boards Drew Fustini
2023-10-23 21:07 ` [PATCH v3 1/7] dt-bindings: mmc: sdhci-of-dwcmhsc: Add T-Head TH1520 support Drew Fustini
2023-10-24 7:39 ` Krzysztof Kozlowski
2023-10-23 21:07 ` [PATCH v3 2/7] mmc: sdhci: add __sdhci_execute_tuning() to header Drew Fustini
2023-10-25 15:29 ` Jisheng Zhang
2023-10-25 18:16 ` Adrian Hunter
2023-10-23 21:07 ` [PATCH v3 3/7] mmc: sdhci-of-dwcmshc: Add support for T-Head TH1520 Drew Fustini
2023-10-25 15:33 ` Jisheng Zhang
2023-10-23 21:07 ` [PATCH v3 4/7] riscv: defconfig: Enable mmc and dma drivers " Drew Fustini
2023-10-23 21:07 ` [PATCH v3 5/7] riscv: dts: thead: Add TH1520 mmc controllers and sdhci clock Drew Fustini
2023-10-23 21:07 ` [PATCH v3 6/7] riscv: dts: thead: Enable BeagleV Ahead eMMC and microSD Drew Fustini
2023-10-24 12:16 ` Emil Renner Berthing [this message]
2023-10-23 21:07 ` [PATCH v3 7/7] riscv: dts: thead: Enable LicheePi 4A " Drew Fustini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJM55Z-OBUsnybSLTxB8RHwsYuWhsMKVH3x8ana4=LeZ98Yv1Q@mail.gmail.com' \
--to=emil.renner.berthing@canonical.com \
--cc=adrian.hunter@intel.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dfustini@baylibre.com \
--cc=gaohan@iscas.ac.cn \
--cc=guoren@kernel.org \
--cc=jkridner@beagleboard.org \
--cc=jszhang@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robertcnelson@beagleboard.org \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wefu@redhat.com \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).