From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C15F7C4332F for ; Fri, 18 Nov 2022 17:33:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242198AbiKRRdv (ORCPT ); Fri, 18 Nov 2022 12:33:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242480AbiKRRdS (ORCPT ); Fri, 18 Nov 2022 12:33:18 -0500 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0584A942F5 for ; Fri, 18 Nov 2022 09:32:29 -0800 (PST) Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 1EAE43F32C for ; Fri, 18 Nov 2022 17:32:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1668792748; bh=fj8UhkKeU72W/99qO15nHbhyif25XpeQl7PAW0nT2E8=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=POuGlPE+NFJOvhT71OwaT/WzFvptG7faZML0qpUeGl7PGg5rhfnHNuDpr1VUfVg/j EXijm9bIsJbBnu2qunLoz/SjtCw9IKGa2UifsSiaxdzMlvZ+MO/GtAbqgY9MAKb4DB XmcE60U6Ufq3HRrycCX6iexw7qKmeLrRPULJjvqlV5jhrv5znEkXfsYRfZqMUmgf0i IZ2AKO4s0xAGlR6lqHg1Sjc1tLzbdUjD0Hpq1zzdSocnVefEcjQTffKtAOhjL113dy KP6S1eTRT9aE+OZiZcuR7ARf+KVaPkR0LvpUrndkwoIvyupk2NK/6OdP6aTn9XbMBj g0jZKGH2tBA5w== Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-368994f4bc0so55112697b3.14 for ; Fri, 18 Nov 2022 09:32:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fj8UhkKeU72W/99qO15nHbhyif25XpeQl7PAW0nT2E8=; b=TQKEx25GAxxwI+96MwdKAQq8IkWMC998zv1htcS/W7NJqaec+5aQyzngLYRELL/wxg xWSf3tVPl95qe2oVgA10fe0S1aHPhWjpjLa40yrh1fYgHYGHdu4mZHkPXGo39yvEcF+n 8sBu0BEuWKADU9gOxZgNu/K6xo9g+0KjvKH0U/IKCULsHPMVEN0AE8AJaVsp7FzxMuNb Z7+JLEuCHxy16tbSJfQ+5u5itPi0DWKZX6WB9WkzbmSFNahzTfwL/2e1izh4T7Bj5yB0 t2tQR4wvcFm0hxURVuPWMkSW5ovuOoSTLIeHv1ZzfUwqFHufTr04KbQDwEELXa2NBUsA qKtQ== X-Gm-Message-State: ANoB5pnagQh/iEQHmsAbZ9BgtmFDPVSLjf4E6OqXPnZHf4+B1NpMvGjP guIasfkcworgT4ZWLn96UMFl5eeC/ul8xHbZSe2+WlpjoAyxJO3gAOnpdK85tyA3O7Ycr/UTO4e q2n7Qxwzm6OdHBQQnc0CWGiPhKZ85esQS2bomcqjQRzf6uqd0lRB8pG8= X-Received: by 2002:a81:9a0b:0:b0:370:2d3:c361 with SMTP id r11-20020a819a0b000000b0037002d3c361mr7344325ywg.251.1668792747076; Fri, 18 Nov 2022 09:32:27 -0800 (PST) X-Google-Smtp-Source: AA0mqf4HcIbrHIRYmL3dgFd+JbwTuttS78s3rG17fVAdC12Ry8v5uY8zZMQE2fsjsQN8AKs73vkYgU2af/B2EOp5ODM= X-Received: by 2002:a81:9a0b:0:b0:370:2d3:c361 with SMTP id r11-20020a819a0b000000b0037002d3c361mr7344294ywg.251.1668792746848; Fri, 18 Nov 2022 09:32:26 -0800 (PST) MIME-Version: 1.0 References: <20221118011714.70877-1-hal.feng@starfivetech.com> <20221118011714.70877-6-hal.feng@starfivetech.com> In-Reply-To: <20221118011714.70877-6-hal.feng@starfivetech.com> From: Emil Renner Berthing Date: Fri, 18 Nov 2022 18:32:10 +0100 Message-ID: Subject: Re: [PATCH v2 5/8] soc: sifive: ccache: Add StarFive JH7110 support To: Hal Feng Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, Conor Dooley , Palmer Dabbelt , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Albert Ou , Ben Dooks , Thomas Gleixner , Marc Zyngier , Stephen Boyd , Michael Turquette , Philipp Zabel , Linus Walleij , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 18 Nov 2022 at 02:17, Hal Feng wrote: > > From: Emil Renner Berthing > > This adds support for the StarFive JH7110 SoC which also > features this SiFive cache controller. > > Signed-off-by: Emil Renner Berthing > Signed-off-by: Hal Feng > --- I'm fine with this, but it would be great if you could add the jh7100 support at the same time like the original patch did. > arch/riscv/Kconfig.socs | 1 + > drivers/soc/Makefile | 2 +- > drivers/soc/sifive/Kconfig | 2 +- > drivers/soc/sifive/sifive_ccache.c | 1 + > 4 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs > index 69774bb362d6..5a40e05f8cab 100644 > --- a/arch/riscv/Kconfig.socs > +++ b/arch/riscv/Kconfig.socs > @@ -22,6 +22,7 @@ config SOC_STARFIVE > bool "StarFive SoCs" > select PINCTRL > select RESET_CONTROLLER > + select SIFIVE_CCACHE > select SIFIVE_PLIC > help > This enables support for StarFive SoC platform hardware. > diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile > index 69ba6508cf2c..534669840858 100644 > --- a/drivers/soc/Makefile > +++ b/drivers/soc/Makefile > @@ -26,7 +26,7 @@ obj-y += qcom/ > obj-y += renesas/ > obj-y += rockchip/ > obj-$(CONFIG_SOC_SAMSUNG) += samsung/ > -obj-$(CONFIG_SOC_SIFIVE) += sifive/ > +obj-y += sifive/ > obj-y += sunxi/ > obj-$(CONFIG_ARCH_TEGRA) += tegra/ > obj-y += ti/ > diff --git a/drivers/soc/sifive/Kconfig b/drivers/soc/sifive/Kconfig > index ed4c571f8771..e86870be34c9 100644 > --- a/drivers/soc/sifive/Kconfig > +++ b/drivers/soc/sifive/Kconfig > @@ -1,6 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0 > > -if SOC_SIFIVE > +if SOC_SIFIVE || SOC_STARFIVE > > config SIFIVE_CCACHE > bool "Sifive Composable Cache controller" > diff --git a/drivers/soc/sifive/sifive_ccache.c b/drivers/soc/sifive/sifive_ccache.c > index 1c171150e878..9489d1a90fbc 100644 > --- a/drivers/soc/sifive/sifive_ccache.c > +++ b/drivers/soc/sifive/sifive_ccache.c > @@ -107,6 +107,7 @@ static const struct of_device_id sifive_ccache_ids[] = { > { .compatible = "sifive,fu540-c000-ccache" }, > { .compatible = "sifive,fu740-c000-ccache" }, > { .compatible = "sifive,ccache0" }, > + { .compatible = "starfive,jh7110-ccache" }, > { /* end of table */ } > }; > > -- > 2.38.1 >