From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1346BC433FE for ; Thu, 24 Nov 2022 09:20:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229908AbiKXJU4 (ORCPT ); Thu, 24 Nov 2022 04:20:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230150AbiKXJUz (ORCPT ); Thu, 24 Nov 2022 04:20:55 -0500 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46D381173C9 for ; Thu, 24 Nov 2022 01:20:51 -0800 (PST) Received: from mail-yb1-f199.google.com (mail-yb1-f199.google.com [209.85.219.199]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 127C23F19F for ; Thu, 24 Nov 2022 09:20:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1669281650; bh=VRx51K+Grac4imHy1DHLCU82k/uWawM5zQfqB1/2368=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=BTSb5oDPfk5kVdVNwh/WPgxbI/s03ycVt3H5olgJTv9wwLfLdHt+lPsGUA1RYeRrr E+QELyzw7H9wkP6y64I6UlTd9z4511LRkY9EsWZ3sKZrfDF0hY8rAx5Q4XHNDuJaxR 6uD28+ZjNaZerOIbKO33njc0E5A0XyiuYi9jTrykz5g1cVgWBFfCafTOtnn427W2pa 3b9mfcDffeaTqB6MQb8HnSpEKSO8r3+Z6+QjACugugQrd5KxD4Jah5SgGHW7lb9uRm hgOueE+0qB0KF6yzt4oNdmqRLD1/k5YurnzaAaxAsh9WFzI5dneKAM4jrCq3vTybq6 Omvj4AS2I7vnA== Received: by mail-yb1-f199.google.com with SMTP id 62-20020a250541000000b006ef62e56e90so1052526ybf.7 for ; Thu, 24 Nov 2022 01:20:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VRx51K+Grac4imHy1DHLCU82k/uWawM5zQfqB1/2368=; b=kd6HmXEC53X/D6GurZYJP3RepkenS3qeTJCcVnTg1N2oa4+Qacg2diOQLaETetBjxL 0dNqCttk0DHRhxhcD7W7vcTMmJ0hKejxCJg5Uva5YZnEr20kgS7JvxyxyG4iBT9/Ph6K FniAKP5n853csR9M7j6V++KZe9zMYx1pQq0uCoU5xs3QwCg188rB34eM95H6kSZQkcUP SKlW7qMaCAm7LFpe5g6E0HGrxGUvA7Bi8K7GGztO0S9iIKpWFe/kZxdLIEI8Jg2hv8US fFIRf6SREFcZHfnGJYs2C7t+SprvbovQY78+UnFyXtJ/umfGIG6v6FYZO47trlCN1K+6 uCIQ== X-Gm-Message-State: ANoB5pn08VdPzehCPcgDZh4W80OVFb2cAdNJp0TjVKKXUBxcQjKJ6xWZ Bv7E5k6Sz64leDaVtDTEgpuxx07jQaPH8kjntqbnlVMfCJqIuJZbKvOifsSVVGyPVsOENhD/6Xz Yp1VEz4bVPzg+aIBMFf+gGo1BNEZ50DTDeMvthhDPqaA14wpl4aZSswc= X-Received: by 2002:a25:4a86:0:b0:6f1:215a:2dbe with SMTP id x128-20020a254a86000000b006f1215a2dbemr3191231yba.469.1669281648229; Thu, 24 Nov 2022 01:20:48 -0800 (PST) X-Google-Smtp-Source: AA0mqf4H7k0go2dHlua8ClKkvM8qah93F0sS9CYUiwz8DhwGeE2xOLmvodSBoY+vtCQ2wxqkd5uAMT6yRu2cukAu/Qc= X-Received: by 2002:a25:4a86:0:b0:6f1:215a:2dbe with SMTP id x128-20020a254a86000000b006f1215a2dbemr3191211yba.469.1669281648005; Thu, 24 Nov 2022 01:20:48 -0800 (PST) MIME-Version: 1.0 References: <20221118011714.70877-1-hal.feng@starfivetech.com> <20221118011714.70877-2-hal.feng@starfivetech.com> <202211190418.2AJ4IQjc072382@SH1-CSMTP-DB111.sundns.com> In-Reply-To: From: Emil Renner Berthing Date: Thu, 24 Nov 2022 10:20:32 +0100 Message-ID: Subject: Re: [PATCH v2 1/8] dt-bindings: riscv: Add StarFive JH7110 SoC and VisionFive2 board To: Hal Feng Cc: "linux-riscv@lists.infradead.org" , "devicetree@vger.kernel.org" , Conor Dooley , Palmer Dabbelt , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Albert Ou , Ben Dooks , Thomas Gleixner , Marc Zyngier , Stephen Boyd , Michael Turquette , Philipp Zabel , Linus Walleij , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, 24 Nov 2022 at 06:56, Hal Feng wrote: > > On Sat, 19 Nov 2022 01:28:48 +0800, Emil Renner Berthing wrote: > > On Fri, 18 Nov 2022 at 02:17, Hal Feng wrote: > > > > > > From: Emil Renner Berthing > > > > > > Add device tree bindings for the StarFive JH7110 RISC-V SoC [1] > > > and the VisionFive2 board [2] equipped with it. > > > > > > [1]: https://doc-en.rvspace.org/Doc_Center/jh7110.html > > > [2]: https://doc-en.rvspace.org/Doc_Center/visionfive_2.html > > > > > > Signed-off-by: Emil Renner Berthing > > > Signed-off-by: Hal Feng > > > --- > > > Documentation/devicetree/bindings/riscv/starfive.yaml | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/riscv/starfive.yaml b/Documentation/devicetree/bindings/riscv/starfive.yaml > > > index 5b36243fd674..64008c57e31f 100644 > > > --- a/Documentation/devicetree/bindings/riscv/starfive.yaml > > > +++ b/Documentation/devicetree/bindings/riscv/starfive.yaml > > > @@ -22,6 +22,10 @@ properties: > > > - const: beagle,beaglev-starlight-jh7100-r0 > > > - const: starfive,jh7100 > > > > > > + - items: > > > + - const: starfive,visionfive-v2 > > > > I think StarFive has switched to just calling it VisionFive 2 and not > > V2. Please check up on this before committing to the compatible > > string. > > > > Also there are going to be different revisions of the VisionFive 2 > > board, so maybe consider adding eg. starfive,visionfive-2-v1.1 and > > starfive,visionfive-2-v1,2b early. > > I checked that the official name of this board is "VisionFive 2". The > board has version A and version B, which are different in gmac and phy > chip. The version A board has one 1000M and one 100M Ethernet ports > while the version B board has two 1000M Ethernet ports. In dts, they > have different configuration parameters for gmac. So I would like to > distinguish them by two compatibles as below in the next version. > > - items: > - enum: > - starfive,visionfive-2-va > - starfive,visionfive-2-vb > - const: starfive,jh7110 Cool. Though the silkscreen on my board says "VisionFive 2 V1.2B" so I think it would be less confusing if you used that as the model, and "starfive,visionfive-2-v1.2b" as the compatible string for the board. > Best regards, > Hal > > > > > > + - const: starfive,jh7110 > > > + > > > additionalProperties: true >