From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB5CC7317D for ; Mon, 29 Apr 2024 13:38:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.125.188.122 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714397925; cv=none; b=P9udCV+I38OUUVg7/7pSnM95R2SnuCg2YartN3ihXtL6yUZ7jNTEu8lOyI9nccBR8xYDKxGvjc9CPFckcv6qgjDqNoutjS2C7e6321CF6i7df4LnWYevqElnDWXHM0ZasDwOwPDvvyHwxf2Fgsf2wmlyjBpdm8eOe1ZiB6L4zC4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714397925; c=relaxed/simple; bh=BgG4r2ZzwmkVHoC8Y+iUIR12GGobZxPL3TajjFp3CA4=; h=From:In-Reply-To:References:Mime-Version:Date:Message-ID:Subject: To:Cc:Content-Type; b=cJglamJ61PA/o+2xlybNQtiiAISOeMePt3DWkaKq1MkRjzLqwrRkZJvMK0IttBtVJD6ugW1sHOACoGWmsXPdyMvIlgat0jVbhKeUZDGkqDGilrFjFcnLT4raSJui/xVJddP+f2CdGkW5V6WRzLfEnKqNBV+MIob6fg4bvuoXqHg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=canonical.com; spf=pass smtp.mailfrom=canonical.com; dkim=pass (2048-bit key) header.d=canonical.com header.i=@canonical.com header.b=pCGJMsAd; arc=none smtp.client-ip=185.125.188.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=canonical.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=canonical.com header.i=@canonical.com header.b="pCGJMsAd" Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 40EFE3F337 for ; Mon, 29 Apr 2024 13:38:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1714397922; bh=kzInz2Vec2Du6of2Q2xRfBv09lBEjQPll+bykpZr/3A=; h=From:In-Reply-To:References:Mime-Version:Date:Message-ID:Subject: To:Cc:Content-Type; b=pCGJMsAdbesIO5ygg3UU/dSWG3Qg8HAkgdKKtP9gtIpmvWefBNOvAIoqFlkmcLNcX OxWpOAtmIhUjr8boeRNL/NYoE4o1+ag5r4RKC7odHo8OuLiMJSTPYx0BOZ8bQns10J A1uYMvBAGE+P3GvMPgHuVwBZdHkzZ5+BygDRR4Re/4mgikEVy6GPttqjJgmlrc6uYw bvp8PsKmcMmcY0z/02itUeeWNe/9CgCUOJ05C+uUL0BIzaM6cB8we6jR5DLa2c3hFM /SJE46Jang73dLYHS0ykJ8Pc6twXOcpdCgRgEEnQH39mmAQIlFr+M3U2pZfqAKLmJ1 ABacP53ckffSQ== Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-43b0fee5f30so3494761cf.3 for ; Mon, 29 Apr 2024 06:38:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714397921; x=1715002721; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kzInz2Vec2Du6of2Q2xRfBv09lBEjQPll+bykpZr/3A=; b=n7TX0lsHwTFHD6D4ZPq30GbMDIQMvayifeW6GeKq99/0SxO/nQ3+LZDW6i4nD6qb++ sG2zYdULgB6a+r8DjsPq+BaA08nr8PzpD0XHXbjPgpZjeqeTafXsPegSAv0YifWTMCZg Ed9/w+GLAEBwxWiCXp3Kx5+A9lVQlwfUpEcl0iFEx7VPhjDDh6tiPbw9XU6sFRZwYDYi +L58tC+cknjnYNlGxTbkmVLy4yPgcLc0FsviC2ju/VAlJlTA3wgRQV976Z/v8VVKolUk fVu52dy1tmwVNeXS7FdKbNsJWQuzZR1BbnlBtVM7u5s8zsRHqfUmDMzztGC4zQTj08kt +TWw== X-Forwarded-Encrypted: i=1; AJvYcCWJ+IhNAu4WBbmtlOhd9juc86E4VjzLcDRm+AZ5J15mgN6H3YS45H5Cjmv0VCaKckvRHCvpBRviAK3zEgLUyPaA7STB+3lV59RklA== X-Gm-Message-State: AOJu0YxIZbha2tq7Pt2oB23kp2stx13b0c8NQR5eZjYsLfVVEGvQZdTu QLFtq96F2WuP40D+K+d7nlBRWhGNVq0k23bygngIxjx50CdcdJnhO913zXC3gGfSfLCoofdKT2Q 0sRl6EIU2op3CCmYPrEJNZkGf+Sb7jJLJSnF5rHGrCl8/RhUWCHAxfpZWL2V46FKIv+fLHI1C98 VwTm4cOfD1lYk2yCszDeZ2UuemM/so7UDzouaeLowHk/sBpk/Qdw== X-Received: by 2002:a05:622a:d2:b0:43a:c1cd:2f54 with SMTP id p18-20020a05622a00d200b0043ac1cd2f54mr5559213qtw.56.1714397921120; Mon, 29 Apr 2024 06:38:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGeybrboGuMYLfrb0LN1/Eksczu7rd1QL7MzncvDdBt5BJRSCjVGbxulLQUKQopeFU++pv+AdoWRrTYLVYMbT4= X-Received: by 2002:a05:622a:d2:b0:43a:c1cd:2f54 with SMTP id p18-20020a05622a00d200b0043ac1cd2f54mr5559199qtw.56.1714397920849; Mon, 29 Apr 2024 06:38:40 -0700 (PDT) Received: from 348282803490 named unknown by gmailapi.google.com with HTTPREST; Mon, 29 Apr 2024 06:38:40 -0700 From: Emil Renner Berthing In-Reply-To: <20240425082138.374445-5-thomas.bonnefille@bootlin.com> References: <20240425082138.374445-1-thomas.bonnefille@bootlin.com> <20240425082138.374445-5-thomas.bonnefille@bootlin.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Date: Mon, 29 Apr 2024 06:38:40 -0700 Message-ID: Subject: Re: [PATCH 4/4] riscv: dts: thead: Enable I2C on the BeagleV-Ahead To: Thomas Bonnefille , jszhang@kernel.org, guoren@kernel.org, wefu@redhat.com, andi.shyti@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: miquel.raynal@bootlin.com, thomas.petazzoni@bootlin.com, linux-riscv@lists.infradead.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu Content-Type: text/plain; charset="UTF-8" Thomas Bonnefille wrote: > This commit enables the I2C0 controller of the TH1520, together with > the FT24C32A EEPROM that is connected to it. > In addition, this commit also enables the I2C controllers I2C2, I2C4 > and I2C5 as they are all three exposed on headers (P9 19 and 20 for I2C2, > P9 17 and 18 for I2C5 and MikroBus 7 and 5 for I2C4). > > Signed-off-by: Thomas Bonnefille > --- > .../boot/dts/thead/th1520-beaglev-ahead.dts | 22 +++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts b/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts > index d9b4de9e4757..22a6935e7204 100644 > --- a/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts > +++ b/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts > @@ -79,3 +79,25 @@ &sdio0 { > &uart0 { > status = "okay"; > }; > + > +&i2c0 { > + status = "okay"; > + clock-frequency = <100000>; > + > + eeprom: eeprom@50 { Nothing seems to reference this. Are you planning on adding adding some code that needs to read this? Otherwise the label is not really needed. > + compatible = "atmel,24c32"; > + reg = <0x50>; > + }; > +}; > + > +&i2c2 { > + status = "okay"; > +}; > + > +&i2c4 { > + status = "okay"; > +}; > + > +&i2c5 { > + status = "okay"; > +}; Does u-boot or some other firmware set up pinctrl for these 3 I2Cs? Otherwise enabling them doesn't really make sense before we have the pinctrl settings for them. /Emil > -- > 2.44.0 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv