From: Emil Renner Berthing <emil.renner.berthing@canonical.com>
To: William Qiu <william.qiu@starfivetech.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-mmc@vger.kernel.org
Cc: Emil Renner Berthing <kernel@esmil.dk>,
Rob Herring <robh+dt@kernel.org>,
Jaehoon Chung <jh80.chung@samsung.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>
Subject: Re: [PATCH 1/3] dt-bindings: mmc: Remove properties from required
Date: Tue, 12 Sep 2023 02:12:44 -0700 [thread overview]
Message-ID: <CAJM55Z_NjSVwCcS0MfHw3mAwsBuScAU0OXX1Ga1+TfQNHKB7Vw@mail.gmail.com> (raw)
In-Reply-To: <20230912081402.51477-1-william.qiu@starfivetech.com>
William Qiu wrote:
> Due to the change of tuning implementation, it's no longer necessary to
> use the "starfive,sysreg" property in dts, so remove it from required.
nit: again the device tree should be a description of the hardware, so the
justification here shouldn't be that the Linux driver doesn't use the field,
but that it turns out the registers aren't required for the peripheral to work
properly. Don't respin the series just for this though.
Reviewed-by: Emil Renner Berthing <emil.renner.berthing@canonical.com>
> Signed-off-by: William Qiu <william.qiu@starfivetech.com>
> ---
> Documentation/devicetree/bindings/mmc/starfive,jh7110-mmc.yaml | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/starfive,jh7110-mmc.yaml b/Documentation/devicetree/bindings/mmc/starfive,jh7110-mmc.yaml
> index 51e1b04e799f..553a75195c2e 100644
> --- a/Documentation/devicetree/bindings/mmc/starfive,jh7110-mmc.yaml
> +++ b/Documentation/devicetree/bindings/mmc/starfive,jh7110-mmc.yaml
> @@ -55,7 +55,6 @@ required:
> - clocks
> - clock-names
> - interrupts
> - - starfive,sysreg
>
> unevaluatedProperties: false
>
> @@ -73,5 +72,4 @@ examples:
> fifo-depth = <32>;
> fifo-watermark-aligned;
> data-addr = <0>;
> - starfive,sysreg = <&sys_syscon 0x14 0x1a 0x7c000000>;
> };
> --
> 2.34.1
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-09-12 9:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 8:13 [PATCH 1/3] dt-bindings: mmc: Remove properties from required William Qiu
2023-09-12 8:13 ` [PATCH 2/3] mmc: starfive: Change tuning implementation William Qiu
2023-09-12 8:13 ` [PATCH 3/3] riscv: dts: starfive: Drop unused properties and limit frquency William Qiu
2023-09-12 8:13 ` [PATCH v2 0/3] Change tuning implementation William Qiu
2023-09-12 17:55 ` Rob Herring
2023-09-12 8:14 ` [PATCH v2 1/3] dt-bindings: mmc: Remove properties from required William Qiu
2023-09-12 16:39 ` Conor Dooley
2023-09-12 8:14 ` [PATCH v2 2/3] mmc: starfive: Change tuning implementation William Qiu
2023-09-12 13:20 ` Emil Renner Berthing
2023-09-12 8:14 ` [PATCH v2 3/3] riscv: dts: starfive: Drop unused properties and limit frquency William Qiu
2023-09-12 13:23 ` Emil Renner Berthing
2023-09-13 10:50 ` William Qiu
2023-09-12 9:12 ` Emil Renner Berthing [this message]
2023-09-12 16:40 ` [PATCH 1/3] dt-bindings: mmc: Remove properties from required Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJM55Z_NjSVwCcS0MfHw3mAwsBuScAU0OXX1Ga1+TfQNHKB7Vw@mail.gmail.com \
--to=emil.renner.berthing@canonical.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jh80.chung@samsung.com \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=william.qiu@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).