From: Hsin-Yi Wang <hsinyi@chromium.org>
To: Pin-Yen Lin <treapking@chromium.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: mt8173: Fix elm panel DT node
Date: Fri, 20 May 2022 16:19:49 +0800 [thread overview]
Message-ID: <CAJMQK-ipc73LUcK9qt8XtadFCiPTF6f_2Nrh_kdkt0UXgNx7ew@mail.gmail.com> (raw)
In-Reply-To: <20220519072649.1493706-1-treapking@chromium.org>
On Thu, May 19, 2022 at 3:27 PM Pin-Yen Lin <treapking@chromium.org> wrote:
>
> Move the panel DT node under `aux-bus` node so it won't use the buggy
> `ps8640_bridge_get_edid` to get display modes. Also change the
> compatible string to "edp-panel" because the predefined
> `lg_lp129qe_mode` is not working.
>
> Signed-off-by: Pin-Yen Lin <treapking@chromium.org>
> Fixes: 689b937bedde ("arm64: dts: mediatek: add mt8173 elm and hana board")
Acked-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
>
> arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 26 +++++++++++---------
> 1 file changed, 14 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> index 9c75fbb31f98..1e0802a6f6d2 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> @@ -90,18 +90,6 @@ volume_up {
> };
> };
>
> - panel: panel {
> - compatible = "lg,lp120up1";
> - power-supply = <&panel_fixed_3v3>;
> - backlight = <&backlight>;
> -
> - port {
> - panel_in: endpoint {
> - remote-endpoint = <&ps8640_out>;
> - };
> - };
> - };
> -
> panel_fixed_3v3: regulator1 {
> compatible = "regulator-fixed";
> regulator-name = "PANEL_3V3";
> @@ -282,6 +270,20 @@ ps8640_out: endpoint {
> };
> };
> };
> +
> + aux-bus {
> + panel {
> + compatible = "edp-panel";
> + power-supply = <&panel_fixed_3v3>;
> + backlight = <&backlight>;
> +
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&ps8640_out>;
> + };
> + };
> + };
> + };
> };
> };
>
> --
> 2.36.1.124.g0e6072fb45-goog
>
prev parent reply other threads:[~2022-05-20 8:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 7:26 [PATCH] arm64: dts: mt8173: Fix elm panel DT node Pin-Yen Lin
2022-05-20 8:19 ` Hsin-Yi Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJMQK-ipc73LUcK9qt8XtadFCiPTF6f_2Nrh_kdkt0UXgNx7ew@mail.gmail.com \
--to=hsinyi@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=enric.balletbo@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=treapking@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).