From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hsin-Yi Wang Subject: Re: [PATCH 2/8] arm64: dts: mt8183: add/update dynamic power coefficients Date: Fri, 3 May 2019 15:16:29 +0800 Message-ID: References: <1556793795-25204-1-git-send-email-michael.kao@mediatek.com> <1556793795-25204-3-git-send-email-michael.kao@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <1556793795-25204-3-git-send-email-michael.kao@mediatek.com> Sender: linux-kernel-owner@vger.kernel.org To: "michael.kao" Cc: fan.chen@mediatek.com, jamesjj.liao@mediatek.com, dawei.chien@mediatek.com, louis.yu@mediatek.com, roger.lu@mediatek.com, Zhang Rui , Eduardo Valentin , Daniel Lezcano , Rob Herring , Mark Rutland , Matthias Brugger , devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org List-Id: devicetree@vger.kernel.org On Thu, May 2, 2019 at 10:43 AM michael.kao wrote: > > Add dynamic power coefficients for all cores and update those of > CPU0 and CPU4. > > Signed-off-by: Michael.Kao > --- > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > index b92116f..5668fb8 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > @@ -58,6 +58,8 @@ > compatible = "arm,cortex-a53"; > reg = <0x000>; > enable-method = "psci"; > + dynamic-power-coefficient = <84>; > + #cooling-cells = <2>; Should this line be in [3/8] arm64: dts: mt8183: Add #cooling-cells to CPU nodes? > }; > > cpu1: cpu@1 { > @@ -65,6 +67,8 @@ > compatible = "arm,cortex-a53"; > reg = <0x001>; > enable-method = "psci"; > + dynamic-power-coefficient = <84>; > + #cooling-cells = <2>; > }; > > cpu2: cpu@2 { > @@ -72,6 +76,8 @@ > compatible = "arm,cortex-a53"; > reg = <0x002>; > enable-method = "psci"; > + dynamic-power-coefficient = <84>; > + #cooling-cells = <2>; > }; > > cpu3: cpu@3 { > @@ -79,6 +85,8 @@ > compatible = "arm,cortex-a53"; > reg = <0x003>; > enable-method = "psci"; > + dynamic-power-coefficient = <84>; > + #cooling-cells = <2>; > }; > > cpu4: cpu@100 { > @@ -86,6 +94,8 @@ > compatible = "arm,cortex-a73"; > reg = <0x100>; > enable-method = "psci"; > + dynamic-power-coefficient = <211>; > + #cooling-cells = <2>; > }; > > cpu5: cpu@101 { > @@ -93,6 +103,8 @@ > compatible = "arm,cortex-a73"; > reg = <0x101>; > enable-method = "psci"; > + dynamic-power-coefficient = <211>; > + #cooling-cells = <2>; > }; > > cpu6: cpu@102 { > @@ -100,6 +112,8 @@ > compatible = "arm,cortex-a73"; > reg = <0x102>; > enable-method = "psci"; > + dynamic-power-coefficient = <211>; > + #cooling-cells = <2>; > }; > > cpu7: cpu@103 { > @@ -107,6 +121,8 @@ > compatible = "arm,cortex-a73"; > reg = <0x103>; > enable-method = "psci"; > + dynamic-power-coefficient = <211>; > + #cooling-cells = <2>; > }; > }; >