From: Matt Ranostay <matt@ranostay.consulting>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
Sebastian Reichel <sre@kernel.org>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH 2/3] devicetree: bq27425: add documentation for bq27425 fuel gauge
Date: Tue, 3 Jan 2017 21:23:55 -0800 [thread overview]
Message-ID: <CAJ_EiSTcpxQVWZALJC_u5P8YM_ku8_wPaiTLyENq5h0XHiQA2g@mail.gmail.com> (raw)
In-Reply-To: <20170103164715.pypb5zt22hg4zqlh@rob-hp-laptop>
On Tue, Jan 3, 2017 at 8:47 AM, Rob Herring <robh@kernel.org> wrote:
> On Sun, Dec 25, 2016 at 09:44:41PM -0800, Matt Ranostay wrote:
>> Signed-off-by: Matt Ranostay <matt@ranostay.consulting>
>> ---
>> .../devicetree/bindings/power/bq27425.txt | 25 ++++++++++++++++++++++
>> 1 file changed, 25 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/power/bq27425.txt
>>
>> diff --git a/Documentation/devicetree/bindings/power/bq27425.txt b/Documentation/devicetree/bindings/power/bq27425.txt
>> new file mode 100644
>> index 000000000000..f09f787a9378
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/power/bq27425.txt
>> @@ -0,0 +1,25 @@
>> +* TI BQ27425 Fuel Gauge
>> +
>> +http://www.ti.com/lit/ds/symlink/bq27425-g2a.pdf
>> +
>> +Please note that if any of the optional properties are defined
>> +then all settings must be.
>> +
>> +Required properties:
>> +- compatible: Should be "ti,bq27425"
>> +- reg: integer, i2c of the device
>
> s/i2c/I2C address/
>
>> +
>> +Optional properties:
>> +- ti,design-capacity: integer of mAh of the battery
>> +- ti,design-energy: integer of the mWh of the battery
>> +- ti,terminate-voltage: integer of mV of the dead voltage of
>> + the battery
>
> These all need unit suffixes. mAh and mWh may need to be added to
> property-units.txt.
Ok makes sense.
>
>> +
>> +bq27425 {
>> + compatible = "ti,bq27425";
>> + reg = <0x55>;
>> +
>> + ti,design-capacity = <1360>;
>> + ti,design-energy = <4970>;
>> + ti,terminate-voltage = <3200>;
>> +};
>> --
>> 2.7.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe devicetree" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-01-04 5:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-26 5:44 [PATCH 0/3] power: bq27xxx: add support for NVRAM R/W access Matt Ranostay
[not found] ` <20161226054442.23599-1-matt-sk+viVC6FLCDq+mSdOJa79kegs52MxvZ@public.gmane.org>
2016-12-26 5:44 ` [PATCH 1/3] bq27xxx_battery: add BQ27425 chip id Matt Ranostay
2016-12-26 5:44 ` [PATCH 2/3] devicetree: bq27425: add documentation for bq27425 fuel gauge Matt Ranostay
[not found] ` <20161226054442.23599-3-matt-sk+viVC6FLCDq+mSdOJa79kegs52MxvZ@public.gmane.org>
2017-01-03 16:47 ` Rob Herring
2017-01-04 5:23 ` Matt Ranostay [this message]
2016-12-26 5:44 ` [PATCH 3/3] power: bq27xxx: add support for NVRAM R/W access Matt Ranostay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ_EiSTcpxQVWZALJC_u5P8YM_ku8_wPaiTLyENq5h0XHiQA2g@mail.gmail.com \
--to=matt@ranostay.consulting \
--cc=devicetree@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).