Re: [PATCH] ARM: dts: kirkwood: Add Zyxel NSA310S board

[Tony Dinh <mibodhi@gmail.com>]

Hi Adam,

On Fri, Oct 28, 2022 at 5:15 PM Adam Baker <linux@baker-net.org.uk> wrote:
>
> On 29/09/2022 13:53, Andrew Lunn wrote:
> >> +// SPDX-License-Identifier: GPL-2.0-only
> > Same license comment. However, you can only change the license if it
> > is your code. If you did the conversion from a board setup file to DT,
> > you can change the license. If somebody else did that and you are just
> > submitting it, then we need to keep to GPL-2.0-only.
>
> As it lists my name in the copyright I'm guessing it is derived from my
> nsa320 device tree.

Yes, I created it based on your device tree DTS from way back. Thanks.

> If so I have no objection to relicensing to GPL2 +
> MIT for anything that came from my code. It is different enough I don't
> think I could reasonably lay claim to it anyway. It looks as though some
> of it such as the keys section came from the earlier nsa310 device tree
> rather than mine. That looks like Andrew Lunn's clean up of it rather
> than Tero Jaasko's original.
>
> There is no temperature or fan monitoring listed in the device tree, do
> you know if the 310s supports it and if so what sensor it uses?

The ZyXEL NAS series 310S/320S/325 don't support the sensor module
(i.e. lm-sensor cannot be used for it). The CPU temperature and fan
speed can be read from i2c, but so far nobody has discovered how to
set them with i2c commands.

All the best,
Tony

>
> Adam Baker
>