From: Jassi Brar <jaswinder.singh@linaro.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: Jassi Brar <jassisinghbrar@gmail.com>,
Devicetree List <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
kernel@stlinux.com
Subject: Re: [PATCH v3 2/5] mailbox: Add support for ST's Mailbox IP
Date: Fri, 2 Oct 2015 15:12:05 +0530 [thread overview]
Message-ID: <CAJe_ZheOw-zG5r-WUd6nYLLmw1QOL8GAXhOmPymm-z2v0oyAGQ@mail.gmail.com> (raw)
In-Reply-To: <20151002093201.GA23213@x1>
On 2 October 2015 at 15:02, Lee Jones <lee.jones@linaro.org> wrote:
> On Fri, 02 Oct 2015, Jassi Brar wrote:
>
>> On Wed, Aug 19, 2015 at 7:52 PM, Lee Jones <lee.jones@linaro.org> wrote:
>>
>> ....
>>
>> > +
>> > +#define MBOX_BASE(mdev, inst) ((mdev)->base + (inst * 4))
>> >
>> It should be (inst) * 4
>
> I'm guessing you mean:
>
> ((mdev)->base + ((inst) * 4))
>
> ?
yes.
next prev parent reply other threads:[~2015-10-02 9:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 14:22 [PATCH v3 0/5] Mailbox: Provide support STi based platforms Lee Jones
[not found] ` <1439994175-13360-1-git-send-email-lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-08-19 14:22 ` [PATCH v3 1/5] mailbox: dt: Supply bindings for ST's Mailbox IP Lee Jones
2015-08-19 14:22 ` [PATCH v3 2/5] mailbox: Add support " Lee Jones
2015-10-02 5:11 ` Jassi Brar
[not found] ` <CABb+yY2wJKBvL3eceVxkq3ZdS6V+-yqQp98YCaS_oR+3CobQ0g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-10-02 9:32 ` Lee Jones
2015-10-02 9:42 ` Jassi Brar [this message]
2015-08-19 14:22 ` [PATCH v3 3/5] ARM: STi: stih407-family: Add nodes for Mailbox Lee Jones
2015-08-19 14:22 ` [PATCH v3 4/5] mailbox: Add generic mechanism for testing Mailbox Controllers Lee Jones
2015-08-19 14:22 ` [PATCH v3 5/5] ARM: STi: DT: STiH407: Enable Mailbox testing facility Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJe_ZheOw-zG5r-WUd6nYLLmw1QOL8GAXhOmPymm-z2v0oyAGQ@mail.gmail.com \
--to=jaswinder.singh@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=kernel@stlinux.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).