From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Subject: Re: [PATCH 2/2] arm64: dts: h6: Add watchdog node Date: Fri, 5 Apr 2019 18:24:53 +0200 Message-ID: References: <20190404135736.8491-1-peron.clem@gmail.com> <20190404135736.8491-2-peron.clem@gmail.com> <20190405090236.e7vnyjzxmzfke3d6@flea> <20190405145005.jmmwsvbateqssbyq@flea> <20190405150810.zjwtu6crzaz6ufhx@flea> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20190405150810.zjwtu6crzaz6ufhx@flea> Sender: linux-kernel-owner@vger.kernel.org To: Maxime Ripard Cc: Chen-Yu Tsai , Rob Herring , Icenowy Zheng , Jagan Teki , devicetree , linux-kernel , linux-arm-kernel , Samuel Holland List-Id: devicetree@vger.kernel.org Hi, On Fri, 5 Apr 2019 at 17:08, Maxime Ripard wrot= e: > > On Fri, Apr 05, 2019 at 10:59:35PM +0800, Chen-Yu Tsai wrote: > > On Fri, Apr 5, 2019 at 10:50 PM Maxime Ripard wrote: > > > > > > On Fri, Apr 05, 2019 at 10:35:08PM +0800, Chen-Yu Tsai wrote: > > > > On Fri, Apr 5, 2019 at 5:02 PM Maxime Ripard wrote: > > > > > > > > > > On Thu, Apr 04, 2019 at 03:57:36PM +0200, Cl=C3=A9ment P=C3=A9ron= wrote: > > > > > > Allwinner H6 has a watchog compatible with A31. > > > > > > > > > > > > Declare it in the device tree. > > > > > > > > > > > > Signed-off-by: Cl=C3=A9ment P=C3=A9ron > > > > > > > > > > Applied both, thanks! > > > > > Maxime > > > > > > > > IIRC there are 3 watchdogs on the H6. One is the trusted watchdog, > > > > which should be reserved for underlying firmware. > > > > > > > > The other two are the normal and R-block watchdog. Although they > > > > look the same, the "normal" one can't reset the system. :( > > > > That one is actually the one ATF currently uses. So reboot doesn't > > > > work on the H6. Some users report that the reboot on the PineH64 actually works. Clement > > > > > > So that patch will not do anything then? > > > > I'm still on vacation, so I haven't checked the address of the new devi= ce. > > If it's the normal one, then yeah, it won't do anything. I've tried tha= t. > > IIRC Samuel (or someone else) on IRC also mentioned this. > > It's the one in the timer that we've used since pretty much day 1 on > older SoCs, so I guess it qualifies as the normal one :) > > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com