devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Clément Péron" <peron.clem@gmail.com>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
	Icenowy Zheng <icenowy@aosc.io>,
	Jagan Teki <jagan@amarulasolutions.com>,
	devicetree <devicetree@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Samuel Holland <samuel@sholland.org>
Subject: Re: [PATCH 2/2] arm64: dts: h6: Add watchdog node
Date: Mon, 8 Apr 2019 23:23:26 +0200	[thread overview]
Message-ID: <CAJiuCcefqtFoSTGRR2J2M0er-d+7+P5oKzDn2shxDustCLdAVQ@mail.gmail.com> (raw)
In-Reply-To: <20190408081635.dlcppclakavwip6v@flea>

On Mon, 8 Apr 2019 at 10:16, Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> On Sun, Apr 07, 2019 at 04:27:36PM +0200, Clément Péron wrote:
> > Hi,
> >
> > On Fri, 5 Apr 2019 at 18:24, Clément Péron <peron.clem@gmail.com> wrote:
> > >
> > > Hi,
> > >
> > > On Fri, 5 Apr 2019 at 17:08, Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > > >
> > > > On Fri, Apr 05, 2019 at 10:59:35PM +0800, Chen-Yu Tsai wrote:
> > > > > On Fri, Apr 5, 2019 at 10:50 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > > > > >
> > > > > > On Fri, Apr 05, 2019 at 10:35:08PM +0800, Chen-Yu Tsai wrote:
> > > > > > > On Fri, Apr 5, 2019 at 5:02 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> > > > > > > >
> > > > > > > > On Thu, Apr 04, 2019 at 03:57:36PM +0200, Clément Péron wrote:
> > > > > > > > > Allwinner H6 has a watchog compatible with A31.
> > > > > > > > >
> > > > > > > > > Declare it in the device tree.
> > > > > > > > >
> > > > > > > > > Signed-off-by: Clément Péron <peron.clem@gmail.com>
> > > > > > > >
> > > > > > > > Applied both, thanks!
> > > > > > > > Maxime
> > > > > > >
> > > > > > > IIRC there are 3 watchdogs on the H6. One is the trusted watchdog,
> > > > > > > which should be reserved for underlying firmware.
> > > > > > >
> > > > > > > The other two are the normal and R-block watchdog. Although they
> > > > > > > look the same, the "normal" one can't reset the system. :(
> > > > > > > That one is actually the one ATF currently uses. So reboot doesn't
> > > > > > > work on the H6.
> > >
> > > Some users report that the reboot on the PineH64 actually works.
> > >
> > > Clement
> > >
> > > > > >
> > > > > > So that patch will not do anything then?
> >
> > Did some test and only interrupts are working right now. If the WDOG
> > is configured to make the board reboot the system will be stuck :S
> > Maybe better to disabled it for now and leave a comment.
>
> I dropped the two patches
What do you think about having it but disabled with a comment ?

I have tested the r_watchdog and this one is functionnal.

Clement

>
> Maxime
>
> --
> Maxime Ripard, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

      reply	other threads:[~2019-04-08 21:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-04 13:57 [PATCH 1/2] dt-bindings: watchdog: sunxi: Add H6 compatible Clément Péron
2019-04-04 13:57 ` [PATCH 2/2] arm64: dts: h6: Add watchdog node Clément Péron
2019-04-05  9:02   ` Maxime Ripard
2019-04-05 14:35     ` Chen-Yu Tsai
2019-04-05 14:50       ` Maxime Ripard
2019-04-05 14:59         ` Chen-Yu Tsai
2019-04-05 15:08           ` Maxime Ripard
2019-04-05 16:24             ` Clément Péron
2019-04-07 14:27               ` Clément Péron
2019-04-08  8:16                 ` Maxime Ripard
2019-04-08 21:23                   ` Clément Péron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJiuCcefqtFoSTGRR2J2M0er-d+7+P5oKzDn2shxDustCLdAVQ@mail.gmail.com \
    --to=peron.clem@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=icenowy@aosc.io \
    --cc=jagan@amarulasolutions.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.ripard@bootlin.com \
    --cc=robh+dt@kernel.org \
    --cc=samuel@sholland.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).