devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Matwey V. Kornilov" <matwey.kornilov@gmail.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Ezequiel Garcia <ezequiel@collabora.com>,
	Akash Gajjar <akash@openedev.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	"moderated list:ARM/Rockchip SoC support" 
	<linux-arm-kernel@lists.infradead.org>,
	"open list:ARM/Rockchip SoC support" 
	<linux-rockchip@lists.infradead.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] arm64: dts: rockchip: Enable PCIe for Radxa Rock Pi 4 board
Date: Mon, 18 Nov 2019 21:40:47 +0300	[thread overview]
Message-ID: <CAJs94EZPLedH4w3+5vfJA+f+1+zLETBdETpqNPytp3LG63az9Q@mail.gmail.com> (raw)
In-Reply-To: <1784520.t1z2W423De@phil>

пн, 18 нояб. 2019 г. в 03:46, Heiko Stuebner <heiko@sntech.de>:
>
> Hi Matwey,
>
> Am Sonntag, 17. November 2019, 11:15:37 CET schrieb Matwey V. Kornilov:
> > Radxa Rock Pi 4 is equipped with M.2 PCIe slot,
> > so enable PCIe for the board.
> >
> > The changes has been tested with Intel SSD 660p series device.
> >
> >     01:00.0 Class 0108: Device 8086:f1a8 (rev 03)
> >
> > Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru>
>
> applied the patch, but you could do a follow-up that mimics
> https://lore.kernel.org/linux-arm-kernel/20191117140728.917-1-linux.amoon@gmail.com/
>
> aka find out from the schematics where the 0.9 and 1.8 supplies come from.

Current schematics
(https://dl.radxa.com/rockpi4/docs/hw/rockpi4/rockpi4_v13_sch_20181112.pdf)
is controversial on 1.8 supply:

On sheet 15 it says that 1.8 is supplied by VCC_1V8
at the same time on sheet 3 it says that it is supplied by VCCA_1V8

>
> Thanks
> Heiko
>
>


-- 
With best regards,
Matwey V. Kornilov

  reply	other threads:[~2019-11-18 18:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-17 10:15 [PATCH v2] arm64: dts: rockchip: Enable PCIe for Radxa Rock Pi 4 board Matwey V. Kornilov
2019-11-18  0:46 ` Heiko Stuebner
2019-11-18 18:40   ` Matwey V. Kornilov [this message]
2019-11-19  0:44     ` Tom Cubie
2019-11-20 16:12       ` [PATCH] arm64: dts: rockchip: Add regulators for " Matwey V. Kornilov
2019-12-13 10:08         ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJs94EZPLedH4w3+5vfJA+f+1+zLETBdETpqNPytp3LG63az9Q@mail.gmail.com \
    --to=matwey.kornilov@gmail.com \
    --cc=akash@openedev.com \
    --cc=devicetree@vger.kernel.org \
    --cc=ezequiel@collabora.com \
    --cc=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).