From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Abraham Subject: Re: [PATCH 3/7] mmc: dw_mmc: add device tree support Date: Thu, 17 May 2012 21:09:21 +0530 Message-ID: References: <1335935266-25289-1-git-send-email-thomas.abraham@linaro.org> <1335935266-25289-4-git-send-email-thomas.abraham@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org To: Guennadi Liakhovetski Cc: linux-mmc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-samsung-soc@vger.kernel.org, patches@linaro.org, linux-kernel@vger.kernel.org, rob.herring@calxeda.com, grant.likely@secretlab.ca, kgene.kim@samsung.com, cjb@laptop.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On 13 May 2012 01:01, Guennadi Liakhovetski wro= te: > Sure. I think, my patch, that I mentioned above, shall be dropped, at > least in its present form. But if at least in principle we do want to= have > a common MMC OF parser for common bindings, some code from your patch > would become redundant, I think. BTW, isn't this > > + =A0 =A0 =A0 gpio =3D of_get_named_gpio(np, "wp_gpios", 0); > > a typo? Shouldn't it be "wp-gpios" instead? Yes, it is a typo. Thanks for your review. This is fixed now. Regards, Thomas.