From: Sachin Kamat <sachin.kamat@samsung.com>
To: Jaewon Kim <jaewon02.kim@samsung.com>
Cc: Ben Dooks <ben-linux@fluff.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
myungjoo.ham@samsung.com, cw00.choi@samsung.com,
Sachin Kamat <spk.linux@gmail.com>
Subject: Re: [PATCH] ARM: dts: exynos4: fix pwm-cells in pwm node
Date: Thu, 12 Jun 2014 14:51:42 +0530 [thread overview]
Message-ID: <CAK5sBcGyDJ9n+_ei_p-5ukW0NMW_ytSXv8dGkkMx2TquDFWBOQ@mail.gmail.com> (raw)
In-Reply-To: <1402561392-21702-1-git-send-email-jaewon02.kim@samsung.com>
Hi Jaewon,
On Thu, Jun 12, 2014 at 1:53 PM, Jaewon Kim <jaewon02.kim@samsung.com> wrote:
> pwm-cells should be 3. Third cell is optional PWM flags.
> And This flag supported by this binding is PWM_POLARITY_INVERTED
>
> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
> ---
> arch/arm/boot/dts/exynos4.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index b8ece4b..b687e53 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -548,13 +548,13 @@
> status = "disabled";
> };
>
> - pwm@139D0000 {
> + pwm: pwm@139D0000 {
unrelated change.
> compatible = "samsung,exynos4210-pwm";
> reg = <0x139D0000 0x1000>;
> interrupts = <0 37 0>, <0 38 0>, <0 39 0>, <0 40 0>, <0 41 0>;
> clocks = <&clock CLK_PWM>;
> clock-names = "timers";
> - #pwm-cells = <2>;
> + #pwm-cells = <3>;
> status = "disabled";
> };
Otherwise looks good.
Reviewed-by: Sachin Kamat <sachin.kamat@samsung.com>
Regards,
Sachin
prev parent reply other threads:[~2014-06-12 9:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-12 8:23 [PATCH] ARM: dts: exynos4: fix pwm-cells in pwm node Jaewon Kim
2014-06-12 9:21 ` Sachin Kamat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK5sBcGyDJ9n+_ei_p-5ukW0NMW_ytSXv8dGkkMx2TquDFWBOQ@mail.gmail.com \
--to=sachin.kamat@samsung.com \
--cc=ben-linux@fluff.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jaewon02.kim@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=myungjoo.ham@samsung.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=spk.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).