From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sachin Kamat Subject: Re: [PATCH] ARM: dts: exynos4: fix pwm-cells in pwm node Date: Thu, 12 Jun 2014 14:51:42 +0530 Message-ID: References: <1402561392-21702-1-git-send-email-jaewon02.kim@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1402561392-21702-1-git-send-email-jaewon02.kim@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org To: Jaewon Kim Cc: Ben Dooks , Kukjin Kim , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , "linux-arm-kernel@lists.infradead.org" , linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, myungjoo.ham@samsung.com, cw00.choi@samsung.com, Sachin Kamat List-Id: devicetree@vger.kernel.org Hi Jaewon, On Thu, Jun 12, 2014 at 1:53 PM, Jaewon Kim wrote: > pwm-cells should be 3. Third cell is optional PWM flags. > And This flag supported by this binding is PWM_POLARITY_INVERTED > > Signed-off-by: Jaewon Kim > --- > arch/arm/boot/dts/exynos4.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi > index b8ece4b..b687e53 100644 > --- a/arch/arm/boot/dts/exynos4.dtsi > +++ b/arch/arm/boot/dts/exynos4.dtsi > @@ -548,13 +548,13 @@ > status = "disabled"; > }; > > - pwm@139D0000 { > + pwm: pwm@139D0000 { unrelated change. > compatible = "samsung,exynos4210-pwm"; > reg = <0x139D0000 0x1000>; > interrupts = <0 37 0>, <0 38 0>, <0 39 0>, <0 40 0>, <0 41 0>; > clocks = <&clock CLK_PWM>; > clock-names = "timers"; > - #pwm-cells = <2>; > + #pwm-cells = <3>; > status = "disabled"; > }; Otherwise looks good. Reviewed-by: Sachin Kamat Regards, Sachin