From: Bryan Wu <cooloney@gmail.com>
To: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Richard Purdie <rpurdie@rpsys.net>,
Grant Likely <grant.likely@linaro.org>,
Courtney Cavin <courtney.cavin@sonymobile.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/2] leds: add DT binding for Qualcomm PM8941 WLED block
Date: Tue, 9 Dec 2014 17:19:10 -0800 [thread overview]
Message-ID: <CAK5ve-+NV2OCKABr16-DfkGre4pM_iEeac8ryY_4ALdEZdeZ1w@mail.gmail.com> (raw)
In-Reply-To: <1418084551-28946-1-git-send-email-bjorn.andersson@sonymobile.com>
On Mon, Dec 8, 2014 at 4:22 PM, Bjorn Andersson
<bjorn.andersson@sonymobile.com> wrote:
> From: Courtney Cavin <courtney.cavin@sonymobile.com>
>
> This adds device tree binding documentation for the WLED ('White' LED)
> block on Qualcomm's PM8941 PMICs.
>
Looks good to me, I need device tree reviewer's Ack to merge it.
Thanks,
-Bryan
> Signed-off-by: Courtney Cavin <courtney.cavin@sonymobile.com>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> ---
> .../devicetree/bindings/leds/leds-pm8941-wled.txt | 43 ++++++++++++++++++++++
> 1 file changed, 43 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/leds-pm8941-wled.txt
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-pm8941-wled.txt b/Documentation/devicetree/bindings/leds/leds-pm8941-wled.txt
> new file mode 100644
> index 0000000..a85a964
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-pm8941-wled.txt
> @@ -0,0 +1,43 @@
> +Binding for Qualcomm PM8941 WLED driver
> +
> +Required properties:
> +- compatible: should be "qcom,pm8941-wled"
> +- reg: slave address
> +
> +Optional properties:
> +- label: The label for this led
> + See Documentation/devicetree/bindings/leds/common.txt
> +- linux,default-trigger: Default trigger assigned to the LED
> + See Documentation/devicetree/bindings/leds/common.txt
> +- qcom,cs-out: bool; enable current sink output
> +- qcom,cabc: bool; enable content adaptive backlight control
> +- qcom,ext-gen: bool; use externally generated modulator signal to dim
> +- qcom,current-limit: mA; per-string current limit; value from 0 to 25
> + default: 20mA
> +- qcom,current-boost-limit: mA; boost current limit; one of:
> + 105, 385, 525, 805, 980, 1260, 1400, 1680
> + default: 805mA
> +- qcom,switching-freq: kHz; switching frequency; one of:
> + 600, 640, 685, 738, 800, 872, 960, 1066, 1200, 1371,
> + 1600, 1920, 2400, 3200, 4800, 9600,
> + default: 1600kHz
> +- qcom,ovp: V; Over-voltage protection limit; one of:
> + 27, 29, 32, 35
> + default: 29V
> +- qcom,num-strings: #; number of led strings attached; value from 1 to 3
> + default: 2
> +
> +Example:
> +
> +pm8941-wled@d800 {
> + compatible = "qcom,pm8941-wled";
> + reg = <0xd800>;
> + label = "backlight";
> +
> + qcom,cs-out;
> + qcom,current-limit = <20>;
> + qcom,current-boost-limit = <805>;
> + qcom,switching-freq = <1600>;
> + qcom,ovp = <29>;
> + qcom,num-strings = <2>;
> +};
> --
> 1.8.2.2
>
next prev parent reply other threads:[~2014-12-10 1:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 0:22 [PATCH 1/2] leds: add DT binding for Qualcomm PM8941 WLED block Bjorn Andersson
2014-12-09 0:22 ` [PATCH 2/2] leds: add Qualcomm PM8941 WLED driver Bjorn Andersson
2014-12-17 0:54 ` Bryan Wu
2014-12-18 23:43 ` Bjorn
2014-12-19 8:15 ` Ivan T. Ivanov
2014-12-17 1:15 ` Stephen Boyd
2014-12-18 23:57 ` Bjorn
2014-12-10 1:19 ` Bryan Wu [this message]
2014-12-17 0:54 ` [PATCH 1/2] leds: add DT binding for Qualcomm PM8941 WLED block Bryan Wu
2014-12-17 1:15 ` Stephen Boyd
2014-12-18 23:36 ` Bjorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK5ve-+NV2OCKABr16-DfkGre4pM_iEeac8ryY_4ALdEZdeZ1w@mail.gmail.com \
--to=cooloney@gmail.com \
--cc=bjorn.andersson@sonymobile.com \
--cc=courtney.cavin@sonymobile.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).