From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Leonard Crestez <leonard.crestez@nxp.com>
Cc: Olof Johansson <olof@lixom.net>, Rob Herring <robh+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Fabio Estevam <fabio.estevam@nxp.com>,
Mark Rutland <mark.rutland@arm.com>,
Aisheng Dong <aisheng.dong@nxp.com>, Leo Li <leoyang.li@nxp.com>,
"linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] kbuild: Add wilddt function instead of listing dtbs
Date: Fri, 25 Jan 2019 01:03:46 +0900 [thread overview]
Message-ID: <CAK7LNAQ+eNhkfNsjGEdAg+j2ButQ8R6NyZ10SckCGSP5MZ4jtg@mail.gmail.com> (raw)
In-Reply-To: <VI1PR04MB553355D6D5EBC2604E1AD256EE9F0@VI1PR04MB5533.eurprd04.prod.outlook.com>
On Tue, Jan 22, 2019 at 1:17 AM Leonard Crestez <leonard.crestez@nxp.com> wrote:
>
> On 1/7/2019 9:31 PM, Leonard Crestez wrote:
> > The dts makefiles go through a lot of pointless churn when boards are
> > added. Many SOCs (such as imx) have very simple naming conventions for
> > all boards using a certain chip and board listings can be easily
> > collapsed using wildcards.
> >
> > Add a "wilddt" function and use it for imx6/7/8 and layerscape. This can
> > be applied to many other soc families later.
> >
> > Previously sent as RFC: https://lore.kernel.org/patchwork/patch/1022737/
>
> Any feedback? This should be reviewed by kbuild and arm-soc
>
> I think this is a worthwhile cleanup, are there any corner cases or more
> exotic setup I should try in order to validate this series?
Personally, I prefer explicit listing
because I can browse the Makefile to get a quick idea
of which boards are compiled.
I like this to be consistent.
- Exploit wildcard for all platforms
or
- Do not do this at all
But, I am pessimistic about the former
when I look at AT91 platform.
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2019-01-24 16:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 19:31 [PATCH 0/3] kbuild: Add wilddt function instead of listing dtbs Leonard Crestez
2019-01-07 19:31 ` [PATCH 1/3] kbuild: Add wilddt function Leonard Crestez
2019-01-07 19:31 ` [PATCH 2/3] ARM: dts: imx: Use " Leonard Crestez
2019-01-07 19:31 ` [PATCH 3/3] arm64: dts: freescale: " Leonard Crestez
2019-01-21 16:16 ` [PATCH 0/3] kbuild: Add wilddt function instead of listing dtbs Leonard Crestez
2019-01-24 16:03 ` Masahiro Yamada [this message]
2019-01-30 13:16 ` Leonard Crestez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNAQ+eNhkfNsjGEdAg+j2ButQ8R6NyZ10SckCGSP5MZ4jtg@mail.gmail.com \
--to=yamada.masahiro@socionext.com \
--cc=aisheng.dong@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=leonard.crestez@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michal.lkml@markovi.net \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).