devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Masahiro Yamada <masahiroy@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
	Rob Herring <robh+dt@kernel.org>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>,
	DTML <devicetree@vger.kernel.org>,
	"moderated list:H8/300 ARCHITECTURE" 
	<uclinux-h8-devel@lists.sourceforge.jp>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] h8300: dts: Fix /chosen:stdout-path
Date: Wed, 3 Jun 2020 14:46:45 +0900	[thread overview]
Message-ID: <CAK7LNARm_EdKTeZj6FUtNnL5oZypPw1mZtcNu7Az86fKjMF24A@mail.gmail.com> (raw)
In-Reply-To: <20200325095326.10875-1-geert+renesas@glider.be>

On Wed, Mar 25, 2020 at 6:53 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
>     arch/h8300/boot/dts/h8s_sim.dts:11.3-25: Warning (chosen_node_stdout_path): /chosen:stdout-path: property is not a string
>     arch/h8300/boot/dts/h8300h_sim.dts:11.3-25: Warning (chosen_node_stdout_path): /chosen:stdout-path: property is not a string
>
> Drop the angle brackets to fix this.
>
> A similar fix was already applied to arch/h8300/boot/dts/edosk2674.dts
> in commit 780ffcd51cb28717 ("h8300: register address fix").
>
> Fixes: 38d6bded13084d50 ("h8300: devicetree source")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>


Reviewed-by: Masahiro Yamada <masahiroy@kernel.org>


Unfortunately, h8300 maintainer is not responding...

How to get this in?

Perhaps, Rob can pick this up?


Thanks.






> ---
>  arch/h8300/boot/dts/h8300h_sim.dts | 2 +-
>  arch/h8300/boot/dts/h8s_sim.dts    | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/h8300/boot/dts/h8300h_sim.dts b/arch/h8300/boot/dts/h8300h_sim.dts
> index 595398b9d0180a80..e1d4d9b7f6b40c04 100644
> --- a/arch/h8300/boot/dts/h8300h_sim.dts
> +++ b/arch/h8300/boot/dts/h8300h_sim.dts
> @@ -8,7 +8,7 @@
>
>         chosen {
>                 bootargs = "earlyprintk=h8300-sim";
> -               stdout-path = <&sci0>;
> +               stdout-path = &sci0;
>         };
>         aliases {
>                 serial0 = &sci0;
> diff --git a/arch/h8300/boot/dts/h8s_sim.dts b/arch/h8300/boot/dts/h8s_sim.dts
> index 932cc3c5a81bcdd2..4848e40e607ecc1d 100644
> --- a/arch/h8300/boot/dts/h8s_sim.dts
> +++ b/arch/h8300/boot/dts/h8s_sim.dts
> @@ -8,7 +8,7 @@
>
>         chosen {
>                 bootargs = "earlyprintk=h8300-sim";
> -               stdout-path = <&sci0>;
> +               stdout-path = &sci0;
>         };
>         aliases {
>                 serial0 = &sci0;
> --
> 2.17.1
>


-- 
Best Regards
Masahiro Yamada

      reply	other threads:[~2020-06-03  5:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-25  9:53 [PATCH] h8300: dts: Fix /chosen:stdout-path Geert Uytterhoeven
2020-06-03  5:46 ` Masahiro Yamada [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK7LNARm_EdKTeZj6FUtNnL5oZypPw1mZtcNu7Az86fKjMF24A@mail.gmail.com \
    --to=masahiroy@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=uclinux-h8-devel@lists.sourceforge.jp \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).