From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Arnd Bergmann <arnd@arndb.de>, arm@kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Marc Zyngier <marc.zyngier@arm.com>
Subject: Re: [Urgent PATCH] arm64: dts: uniphier: fix IRQ trigger type of ARMv8 timer
Date: Thu, 11 Aug 2016 11:25:30 +0900 [thread overview]
Message-ID: <CAK7LNAT5D0HmvpVPnX1oFw=KJSOavVjXT6ECHBuTOhNaKpdQLg@mail.gmail.com> (raw)
In-Reply-To: <CAK7LNAQo6Si9q0FQw=3i67yGO1JYuDxHBB=xsLZOj8S-TBG_Rg@mail.gmail.com>
Hi Arnd,
2016-08-01 17:26 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> Hi Marc,
>
> 2016-08-01 17:18 GMT+09:00 Marc Zyngier <marc.zyngier@arm.com>:
>> Please keep me cc-ed on this.
>
> Sorry, I automate patch-posting, but scripts/get_maintainer.pl
> did not pick you up. Also, I forgot to cc you explicitly.
>
>
>> On 01/08/16 09:12, Masahiro Yamada wrote:
>>> Since commit 1e2a7d78499e ("irqdomain: Don't set type when mapping
>>> an IRQ"), the interrupt type is strictly checked. Without this
>>> patch, this board would not boot any more.
>>>
>>> Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt
>>> says that the 3rd cell should be either 1 (edge) or 4 (level)
>>> depending on the trigger type. As the CA72 Generic Timer provides
>>> active-low interrupts, the value of the 3rd cell should be 4.
>>>
>>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>>> Suggested-by: Marc Zyngier <marc.zyngier@arm.com>
>>> ---
>>> Arnd, Olof,
>>>
>>> I guess you are about to send pull-reqs for v4.8 cycle.
>>> Could you include this one in them?
>>> After IRQ updates for 4.8 were merged, my board would not
>>> boot at all. I consulted experts and looks like my DT
>>> was wrong.
>>>
>>> I could do this after -rc1 is out because it is apparently a
>>> bug fix, but in that case the for-next branch in ASOC will be
>>> broken for me, which would make bisect-ability difficult for me.
>>
>> I have a patch that addresses all platforms in one go (there is really
>> no point in fixing one at a time for a bug that is so widespread).
>>
>> I'll repost it later today.
>>
>
> That'll be fine.
> Thank you!
>
>
> Arnd, Olof:
> Please disregard this one.
>
Oh Dear.
Did you apply this one?
This was replaced with Marc'one:
https://patchwork.kernel.org/patch/9254183/
Is it too late?
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2016-08-11 2:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 8:12 [Urgent PATCH] arm64: dts: uniphier: fix IRQ trigger type of ARMv8 timer Masahiro Yamada
2016-08-01 8:18 ` Marc Zyngier
2016-08-01 8:26 ` Masahiro Yamada
2016-08-11 2:25 ` Masahiro Yamada [this message]
2016-08-11 6:44 ` Arnd Bergmann
[not found] ` <1470039140-3801-1-git-send-email-yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org>
2016-08-10 20:52 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNAT5D0HmvpVPnX1oFw=KJSOavVjXT6ECHBuTOhNaKpdQLg@mail.gmail.com' \
--to=yamada.masahiro@socionext.com \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).