devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
	Rob Herring <robh+dt@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	Jonathan Corbet <corbet@lwn.net>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	linux-stm32@st-md-mailman.stormreply.com,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	DTML <devicetree@vger.kernel.org>,
	"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>
Subject: Re: [PATCH 0/7] Add STM32MP13 SoCs and discovery board support
Date: Fri, 23 Jul 2021 15:46:14 +0200	[thread overview]
Message-ID: <CAK8P3a1ax29ThCG867phtx1Xb12GgiJFcLDd8H9VLbsJQ1uoAw@mail.gmail.com> (raw)
In-Reply-To: <20210723132810.25728-1-alexandre.torgue@foss.st.com>

On Fri, Jul 23, 2021 at 3:28 PM Alexandre Torgue
<alexandre.torgue@foss.st.com> wrote:
>
> This series enhance the STM32 MPU family by adding STM32MP13 SoCs support.
> It adds machine support and device tree diversity to support the whole
> stm32mp13 family (STM32MP131/STM32MP133/STM32MP135, plus security feature
> diversity).
>
> Basically STM32MP13 SoCs embeds one Cortex A7, storage (SD/MMC/SDIO, QSPI FMC),
> network (ETH, CAN), display (DCMIPP, LTDC, ...), audio(SAI, DFSDM, SPDIFRX),
> com (USB EHCI/OHCI, USB OTG, I2C, SPI/I2S, U(S)ART).
>
> This series also adds STM32MP135F Discovery board support (stm32mp135f-dk). It
> embeds a STM32MP135f SOC with 512 MB of DDR3. Several connections are available
> on this board:
>  - 4*USB2.0, 1*USB2.0 typeC DRD, SDcard, 2*RJ45, HDMI, Combo Wifi/BT, ...
>
> Only SD card, uart4 (console) and watchdog IPs are enabled in this commit.
>
> Note that file stm32mp135.dtsi doesn't define nodes but I add it now to ease adding
> of new nodes in a (close) future.

I had a brief look and it seems all fine to me, nice work!

The only (very minor) thing I noticed is that the crypto engine device node
has an unusual name 'cryp@' instead of the usual 'crypto@', but this is already
the case on stm32mp157.

With this changed,

Acked-by: Arnd Bergmann <arnd@arndb.de

  parent reply	other threads:[~2021-07-23 13:46 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-23 13:28 [PATCH 0/7] Add STM32MP13 SoCs and discovery board support Alexandre Torgue
2021-07-23 13:28 ` [PATCH 1/7] dt-bindings: pinctrl: stm32: add new compatible for STM32MP135 SoC Alexandre Torgue
2021-07-29 20:34   ` Rob Herring
2021-08-05 14:29   ` Alexandre TORGUE
2021-08-10 12:45   ` Linus Walleij
2021-07-23 13:28 ` [PATCH 2/7] pinctrl: stm32: Add STM32MP135 SoC support Alexandre Torgue
2021-08-10 12:45   ` Linus Walleij
2021-07-23 13:28 ` [PATCH 3/7] docs: arm: stm32: introduce STM32MP13 SoCs Alexandre Torgue
2021-07-23 13:28 ` [PATCH 4/7] ARM: stm32: add initial support for STM32MP13 family Alexandre Torgue
2021-07-23 13:28 ` [PATCH 5/7] ARM: dts: stm32: add STM32MP13 SoCs support Alexandre Torgue
2021-07-23 14:10   ` [Linux-stm32] " Ahmad Fatoum
2021-07-23 13:28 ` [PATCH 6/7] dt-bindings: stm32: document stm32mp135f-dk board Alexandre Torgue
2021-07-29 20:34   ` Rob Herring
2021-07-23 13:28 ` [PATCH 7/7] ARM: dts: stm32: add initial support of " Alexandre Torgue
2021-07-23 13:46 ` Arnd Bergmann [this message]
2021-07-23 14:36   ` [PATCH 0/7] Add STM32MP13 SoCs and discovery board support Alexandre TORGUE
2021-09-20  7:37 ` Alexandre TORGUE

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK8P3a1ax29ThCG867phtx1Xb12GgiJFcLDd8H9VLbsJQ1uoAw@mail.gmail.com \
    --to=arnd@arndb.de \
    --cc=alexandre.torgue@foss.st.com \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=linux@armlinux.org.uk \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=olof@lixom.net \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).