From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0FD1C63793 for ; Thu, 22 Jul 2021 10:28:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 995856127C for ; Thu, 22 Jul 2021 10:28:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231607AbhGVJsT (ORCPT ); Thu, 22 Jul 2021 05:48:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:58230 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231609AbhGVJsS (ORCPT ); Thu, 22 Jul 2021 05:48:18 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 092F06128A; Thu, 22 Jul 2021 10:28:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626949734; bh=dKkz0H90g75Jqm7Tv0Fj0nBgj32L9xL5yzrVGuWSxd0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Ehlhd1I88u+UOpYo4uuAqDJZmujkb/zzPVO68lh4VsKsGbAS0GQ4bffDY+AG8w1FN uINgg9X0Rsdhl2h4+yj5HePRqRoB264TqfSaruZmiSobSFjJGp4yKJDNlq3p/QAKn5 S4jscchMtclnJUaMy1PTWXVl8S3bsnHLdoeE5jLZLiCBMc44WNJOfxYJvLo+Gg4OQd g+3jlWjNayJINWCR10so/xuaYvomJM2mSIdsawcrv64x8LC91MYl1ohNrNvcCZBWUS lMcRBX8wZRdPfVe/caUtmAqM93EvkNz63XlJ3f+QPibA5XWwcTAx7s3jufOwqxkKa+ pMd9MR3d8cmjQ== Received: by mail-wr1-f52.google.com with SMTP id l7so5358077wrv.7; Thu, 22 Jul 2021 03:28:53 -0700 (PDT) X-Gm-Message-State: AOAM53153SNi2JjWR+VIKnFtQdkm/AyknUsh8Ne/rsSMWuVUpaBscb9d Eek1s9igm2GwtNg60+UhQXiu9b9kayry1P5TrRo= X-Google-Smtp-Source: ABdhPJxkSjTrQb/uN1KPB9MMMTm3daq3N1zrgRlAILlwLCIncbFfzr7m2+3Hu4Gw+BnhPDcRx+BoGjl3//ybpEvYzYw= X-Received: by 2002:a5d:65cb:: with SMTP id e11mr49542874wrw.105.1626949732596; Thu, 22 Jul 2021 03:28:52 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Arnd Bergmann Date: Thu, 22 Jul 2021 12:28:36 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V2 1/5] dt-bindings: virtio: Add binding for virtio devices To: Viresh Kumar Cc: Jason Wang , "Michael S. Tsirkin" , Rob Herring , Jean-Philippe Brucker , Vincent Guittot , Bill Mills , =?UTF-8?B?QWxleCBCZW5uw6ll?= , "Enrico Weigelt, metux IT consult" , Jie Deng , DTML , Linux Kernel Mailing List , "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Jul 22, 2021 at 11:57 AM Viresh Kumar wrote: > > Allow virtio device sub-nodes to be added to the virtio mmio or pci > nodes. The compatible property for virtio device must be of format > "virtio,", where DID is virtio device ID in hexadecimal format. > > Signed-off-by: Viresh Kumar Looks good to me overall. One question would be for the exact format of the 'compatible' string. After seeing this version, I would slightly prefer "virtio,device22" over "virtio,22". I think in the previous version we had mentioned both, but not actually decided on which one to use. Arnd