From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09A9AEB64D9 for ; Thu, 15 Jun 2023 05:47:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230003AbjFOFre (ORCPT ); Thu, 15 Jun 2023 01:47:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229530AbjFOFrb (ORCPT ); Thu, 15 Jun 2023 01:47:31 -0400 Received: from mail-yw1-x1133.google.com (mail-yw1-x1133.google.com [IPv6:2607:f8b0:4864:20::1133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20A5C1BEC for ; Wed, 14 Jun 2023 22:47:30 -0700 (PDT) Received: by mail-yw1-x1133.google.com with SMTP id 00721157ae682-5700e993f37so6876457b3.0 for ; Wed, 14 Jun 2023 22:47:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1686808049; x=1689400049; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9vDiV6UeFt2Sno0zSEPfAoE+c0aIDiDuPDDc3lI/OiI=; b=NnXGhiSIhqovytwTJdiQfnf5eovw73VQ87w+m9529YHgbOMhDe7l4LCL5NtOB6593B o90sc0F6F9c09Iv0yyo0gUhUtyFvhyXuclonV56OHBilEhgzNLnNA+mQBnM5tEm08uX1 E+B3T2gkNTeMf5GZ4CeYbmNSoiMrxj8FjlDU4jDDz3/8wzn5i6yXoUy/FOoMQHKwWlFQ lMlEbhsKnb88uhsz/UH/OEAnb4OKRp1J6+phEMcdLTzi6PJNQm+XYWetoWUHArEEdu2p S8sVkzseIZByhGC+iZEq3fFyIlChqUaRGD9VkoATiH9Z8PQiOVakQk4O8KHlEYkLk6OX J+BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686808049; x=1689400049; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9vDiV6UeFt2Sno0zSEPfAoE+c0aIDiDuPDDc3lI/OiI=; b=PWH/cE0flSI5CKJwda9G5Hyb9N42hWH1tPntnhOmuYvUxXAKhRv0uzeVfXO6rCc3v4 Fma7sYbBesDVFPvR808G/ncpDQB6uWOR1K7HqdbQgi5vI714wbksHQ4nciNGtfdGaJNQ HMSLasamXf0vyq3qHOCSeGHFWx1HxuRGX+y/YRyZiLvsjcEPyRXUEKoUOiTsXCzpRVTl 7xQ/+yvYov6wo7R3EIlGx5zdRRRdRjDSCG9NkoCD9SOpJfq8+RTZjIetQQ+jk/pAM/WO 0vCRPsz0/aosr8JbbKXNZCEZKx8/yEY8s/y5y+1x73ugS05my7YTwMv0JLt7hF1PWMs6 EUUQ== X-Gm-Message-State: AC+VfDyT30U2QtqmUQ49w0iEuKZHorOHYnznmhr9DiHjzZmSTLZ4IkOm hWDndYL92CbnyGAfH0nUvbOkipV5nlJImQtWsXLuhQ== X-Google-Smtp-Source: ACHHUZ6aKGXwe4EbTAHJQ5c1CR4NVyX6sBaLo3x4BgIGK1ahNs5xjRNtb+Y/FJFgCgD+L1CXMRjT+B82WtWhsEiWxk0= X-Received: by 2002:a0d:ea51:0:b0:570:2a0:6c18 with SMTP id t78-20020a0dea51000000b0057002a06c18mr4459993ywe.2.1686808049229; Wed, 14 Jun 2023 22:47:29 -0700 (PDT) MIME-Version: 1.0 References: <20230613153415.350528-1-apatel@ventanamicro.com> <20230613153415.350528-8-apatel@ventanamicro.com> <20230614-devotee-repave-37d670dbfb7c@spud> In-Reply-To: <20230614-devotee-repave-37d670dbfb7c@spud> From: Anup Patel Date: Thu, 15 Jun 2023 11:17:16 +0530 Message-ID: Subject: Re: [PATCH v4 07/10] dt-bindings: interrupt-controller: Add RISC-V advanced PLIC To: Conor Dooley Cc: Palmer Dabbelt , Paul Walmsley , Thomas Gleixner , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Robin Murphy , Joerg Roedel , Will Deacon , Frank Rowand , Atish Patra , Andrew Jones , Saravana Kannan , Anup Patel , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, iommu@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Jun 15, 2023 at 12:57=E2=80=AFAM Conor Dooley wr= ote: > > Hey Anup, > > Mostly looks good, once minor comment. > > On Tue, Jun 13, 2023 at 09:04:12PM +0530, Anup Patel wrote: > > > + riscv,children: > > + $ref: /schemas/types.yaml#/definitions/phandle-array > > + minItems: 1 > > + maxItems: 1024 > > + items: > > + maxItems: 1 > > + description: > > + A list of child APLIC domains for the given APLIC domain. Each c= hild > > + APLIC domain is assigned a child index in increasing order, with= the > > + first child APLIC domain assigned child index 0. The APLIC domai= n child > > + index is used by firmware to delegate interrupts from the given = APLIC > > + domain to a particular child APLIC domain. > > + > > + riscv,delegation: > > + $ref: /schemas/types.yaml#/definitions/phandle-array > > + minItems: 1 > > + maxItems: 1024 > > + items: > > + items: > > + - description: child APLIC domain phandle > > + - description: first interrupt number of the parent APLIC doma= in (inclusive) > > + - description: last interrupt number of the parent APLIC domai= n (inclusive) > > + description: > > + A interrupt delegation list where each entry is a triple consist= ing > > + of child APLIC domain phandle, first interrupt number of the par= ent > > + APLIC domain, and last interrupt number of the parent APLIC doma= in. > > + Firmware must configure interrupt delegation registers based on > > + interrupt delegation list. > > + > > +required: > > + - compatible > > + - reg > > + - interrupt-controller > > + - "#interrupt-cells" > > + - riscv,num-sources > > + > > +anyOf: > > + - required: > > + - interrupts-extended > > + - required: > > + - msi-parent > > Not sure if you missed this from the last version, but I asked if we > needed a > dependencies: > riscv,delegate: [ riscv,children ] > > IOW, I don't think it is valid to have a delegation without having > children? Ahh, yes. I missed this one. I will update in the next revision. > > Otherwise, > Reviewed-by: Conor Dooley > > Cheers, > Conor. Regards, Anup