From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED5D8C4320A for ; Mon, 23 Aug 2021 01:08:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D475061262 for ; Mon, 23 Aug 2021 01:08:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234556AbhHWBIn (ORCPT ); Sun, 22 Aug 2021 21:08:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234471AbhHWBIm (ORCPT ); Sun, 22 Aug 2021 21:08:42 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C84F7C06175F for ; Sun, 22 Aug 2021 18:08:00 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id bt14so33454536ejb.3 for ; Sun, 22 Aug 2021 18:08:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=T5y7wVd3UOjVoEbI5ONgdC3uXVDViTEHAaSeTJ0ja4U=; b=h0t9/9UfiLyNfrXy6i0QXamegtgkKo10OoklxRz3R26HLZl3qSFetS66GnthOrWnFf 8PykNkBM5JtaKkf7uWyRaN89t138vt/k5ZFqskLgc2pFLnrMvajgV8sWsKyLI7CVyw5L FOtjL9mWdRKC/LfK7HLFayYeNxmQBONc909smYGw0rf7A1TC/wLwEkixK7SVhue9ER5r XVkPy8Bm3BSgyC+Ela1I18JEE0ZGtFWcBI0tKH5q7eqCZ1U9D9pnxZ259b4JW2pwBMPD xetYuva9J0p3LJ+wLpd7LmG3bj1jYwgCb7iUpo1GhKG/y4d4XZxJJbI1yAX1LnIn1uT9 dTyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=T5y7wVd3UOjVoEbI5ONgdC3uXVDViTEHAaSeTJ0ja4U=; b=TwTwitTOmS7oDIstbVrbJ3LAzCu7YKdD0sjYHNP5MCdpv7HZ2pt8me1vWl5ppN1ve+ 4kZxc7EoEJ31qfPZJOUr887/I5eydWJcp/ck7CvgrHCJiUstGOe1VemZj5G5HSO2aZH8 Cmixt4OqKLpQivF0Fpht/+C1kfH1oDDM2/eE9z7v5tWEgQj4v8duLVyH22uTe3DBltqi g/yoxtTGknH3nLWDYctDxC+kgGKk4VNl4PgOHOTIQqP6GJjHaEoZv3YoRL3oONWvfWv6 YIIU+1W1HPmKug0YncvSQFKGzhrOhsy8iK+OxREGYXJlGTbYJDuFWXdB3TghLyipR1QA Y61Q== X-Gm-Message-State: AOAM532q57ZaVG3d3Xz5blpPQeZQTFqdl0u5Pvxcbds9KK74mHO6Vg41 GOXNIaaNXOU7YOe1Ur5uxQZglCBBawWOQDhOxs740w== X-Google-Smtp-Source: ABdhPJz0StLU+fjdzYTuDDRKxp8saXqBpf1ETE1pQ01x6B/7KvW0AELfBnJQYQyaNAKcNTY+WEiB0NIW5O91SEGzLTA= X-Received: by 2002:a17:906:2305:: with SMTP id l5mr33404768eja.72.1629680879402; Sun, 22 Aug 2021 18:07:59 -0700 (PDT) MIME-Version: 1.0 References: <20210304034141.7062-1-brad@pensando.io> <20210304034141.7062-2-brad@pensando.io> <605880ad-6c12-bf1d-45f8-ef70181e4eec@canonical.com> In-Reply-To: <605880ad-6c12-bf1d-45f8-ef70181e4eec@canonical.com> From: Brad Larson Date: Sun, 22 Aug 2021 18:07:48 -0700 Message-ID: Subject: Re: [PATCH 1/8] gpio: Add Elba SoC gpio driver for spi cs control To: Krzysztof Kozlowski Cc: Linux ARM , Arnd Bergmann , Linus Walleij , Bartosz Golaszewski , Mark Brown , Serge Semin , Adrian Hunter , Ulf Hansson , Olof Johansson , "open list:GPIO SUBSYSTEM" , linux-spi , linux-mmc , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Krzysztof, On Fri, Mar 5, 2021 at 3:25 AM Krzysztof Kozlowski wrote: > > On 04/03/2021 04:41, Brad Larson wrote: > > This GPIO driver is for the Pensando Elba SoC which > > provides control of four chip selects on two SPI busses. [...] > > + ret = devm_gpiochip_add_data(&pdev->dev, &p->chip, p); > > + if (ret) { > > + dev_err(&pdev->dev, "unable to add gpio chip\n"); > > + return ret; > > + } > > + > > + dev_info(&pdev->dev, "elba spics registered\n"); > > Don't print trivial probe results, unless you print here something > useful. If you need it for debugging, keep it dev_dbg. Removed that extraneous logging Regards, Brad