From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sachin Kamat Subject: Re: [PATCH] i2c-s3c2410: Fix potential NULL pointer dereference Date: Wed, 26 Sep 2012 09:37:31 +0530 Message-ID: References: <1347958128-13146-1-git-send-email-sachin.kamat@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: <1347958128-13146-1-git-send-email-sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, Wolfram Sang , Grant Likely , Rob Herring List-Id: devicetree@vger.kernel.org Hi, Can we have this fix for the 3.6 series please? On 18 September 2012 14:18, Sachin Kamat wrote: > of_match_node() returns NULL if a device_node does not have > a matching of_match structure. Thus the return value needs to be > checked for NULL to avoid NULL pointer dereferencing. > > Cc: Wolfram Sang > Cc: Grant Likely > Cc: Rob Herring > Signed-off-by: Sachin Kamat > --- > drivers/i2c/busses/i2c-s3c2410.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c > index 5ae3b02..d906523 100644 > --- a/drivers/i2c/busses/i2c-s3c2410.c > +++ b/drivers/i2c/busses/i2c-s3c2410.c > @@ -123,6 +123,8 @@ static inline unsigned int s3c24xx_get_device_quirks(struct platform_device *pde > if (pdev->dev.of_node) { > const struct of_device_id *match; > match = of_match_node(s3c24xx_i2c_match, pdev->dev.of_node); > + if (!match) > + return 0; > return (unsigned int)match->data; > } > > -- > 1.7.4.1 > -- With warm regards, Sachin