Re: [PATCH] ARM: dts: Modify SPI nodes according generic DMA DT bindings

[Sachin Kamat <sachin.kamat@linaro.org>]

On 5 March 2013 15:34, Padmavathi Venna <padma.v@samsung.com> wrote:
> This patch removes custom way of adding spi dma channels and
> adds according to new generic DMA DT bindings on samsung exynos4
> and exynos5440 platforms.
>
> Signed-off-by: Padmavathi Venna <padma.v@samsung.com>
> ---
>  arch/arm/boot/dts/exynos4.dtsi    |   15 +++++++++------
>  arch/arm/boot/dts/exynos5440.dtsi |    5 +++--
>  2 files changed, 12 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index 1a62bcf..2449651 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -235,8 +235,9 @@
>                 compatible = "samsung,exynos4210-spi";
>                 reg = <0x13920000 0x100>;
>                 interrupts = <0 66 0>;
> -               tx-dma-channel = <&pdma0 7>; /* preliminary */
> -               rx-dma-channel = <&pdma0 6>; /* preliminary */
> +               dmas = <&pdma0 7
> +                       &pdma0 6>;
> +               dma-names = "tx", "rx";
>                 #address-cells = <1>;
>                 #size-cells = <0>;
>                 status = "disabled";
> @@ -246,8 +247,9 @@
>                 compatible = "samsung,exynos4210-spi";
>                 reg = <0x13930000 0x100>;
>                 interrupts = <0 67 0>;
> -               tx-dma-channel = <&pdma1 7>; /* preliminary */
> -               rx-dma-channel = <&pdma1 6>; /* preliminary */
> +               dmas = <&pdma0 7
> +                       &pdma0 6>;

Shouldn't these be pdma1 as was earlier?