* [PATCH] ARM: dts: Modify SPI nodes according generic DMA DT bindings
@ 2013-03-05 10:04 Padmavathi Venna
2013-03-05 10:06 ` Sachin Kamat
0 siblings, 1 reply; 4+ messages in thread
From: Padmavathi Venna @ 2013-03-05 10:04 UTC (permalink / raw)
To: linux-samsung-soc, devicetree-discuss, linux-arm-kernel, padma.v,
padma.kvr
Cc: sbkim73, broonie, kgene.kim, arnd, vinod.koul, grant.likely
This patch removes custom way of adding spi dma channels and
adds according to new generic DMA DT bindings on samsung exynos4
and exynos5440 platforms.
Signed-off-by: Padmavathi Venna <padma.v@samsung.com>
---
arch/arm/boot/dts/exynos4.dtsi | 15 +++++++++------
arch/arm/boot/dts/exynos5440.dtsi | 5 +++--
2 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index 1a62bcf..2449651 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -235,8 +235,9 @@
compatible = "samsung,exynos4210-spi";
reg = <0x13920000 0x100>;
interrupts = <0 66 0>;
- tx-dma-channel = <&pdma0 7>; /* preliminary */
- rx-dma-channel = <&pdma0 6>; /* preliminary */
+ dmas = <&pdma0 7
+ &pdma0 6>;
+ dma-names = "tx", "rx";
#address-cells = <1>;
#size-cells = <0>;
status = "disabled";
@@ -246,8 +247,9 @@
compatible = "samsung,exynos4210-spi";
reg = <0x13930000 0x100>;
interrupts = <0 67 0>;
- tx-dma-channel = <&pdma1 7>; /* preliminary */
- rx-dma-channel = <&pdma1 6>; /* preliminary */
+ dmas = <&pdma0 7
+ &pdma0 6>;
+ dma-names = "tx", "rx";
#address-cells = <1>;
#size-cells = <0>;
status = "disabled";
@@ -257,8 +259,9 @@
compatible = "samsung,exynos4210-spi";
reg = <0x13940000 0x100>;
interrupts = <0 68 0>;
- tx-dma-channel = <&pdma0 9>; /* preliminary */
- rx-dma-channel = <&pdma0 8>; /* preliminary */
+ dmas = <&pdma0 9
+ &pdma0 8>;
+ dma-names = "tx", "rx";
#address-cells = <1>;
#size-cells = <0>;
status = "disabled";
diff --git a/arch/arm/boot/dts/exynos5440.dtsi b/arch/arm/boot/dts/exynos5440.dtsi
index 9a99755..31a3626 100644
--- a/arch/arm/boot/dts/exynos5440.dtsi
+++ b/arch/arm/boot/dts/exynos5440.dtsi
@@ -79,8 +79,9 @@
compatible = "samsung,exynos4210-spi";
reg = <0xD0000 0x1000>;
interrupts = <0 4 0>;
- tx-dma-channel = <&pdma0 5>; /* preliminary */
- rx-dma-channel = <&pdma0 4>; /* preliminary */
+ dmas = <&pdma0 5
+ &pdma0 4>;
+ dma-names = "tx", "rx";
#address-cells = <1>;
#size-cells = <0>;
};
--
1.7.4.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: Modify SPI nodes according generic DMA DT bindings
2013-03-05 10:04 [PATCH] ARM: dts: Modify SPI nodes according generic DMA DT bindings Padmavathi Venna
@ 2013-03-05 10:06 ` Sachin Kamat
2013-03-05 10:19 ` Padma Venkat
2013-03-05 10:24 ` Sylwester Nawrocki
0 siblings, 2 replies; 4+ messages in thread
From: Sachin Kamat @ 2013-03-05 10:06 UTC (permalink / raw)
To: Padmavathi Venna
Cc: linux-samsung-soc, devicetree-discuss, linux-arm-kernel,
padma.kvr, sbkim73, broonie, kgene.kim, arnd, vinod.koul,
grant.likely
On 5 March 2013 15:34, Padmavathi Venna <padma.v@samsung.com> wrote:
> This patch removes custom way of adding spi dma channels and
> adds according to new generic DMA DT bindings on samsung exynos4
> and exynos5440 platforms.
>
> Signed-off-by: Padmavathi Venna <padma.v@samsung.com>
> ---
> arch/arm/boot/dts/exynos4.dtsi | 15 +++++++++------
> arch/arm/boot/dts/exynos5440.dtsi | 5 +++--
> 2 files changed, 12 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index 1a62bcf..2449651 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -235,8 +235,9 @@
> compatible = "samsung,exynos4210-spi";
> reg = <0x13920000 0x100>;
> interrupts = <0 66 0>;
> - tx-dma-channel = <&pdma0 7>; /* preliminary */
> - rx-dma-channel = <&pdma0 6>; /* preliminary */
> + dmas = <&pdma0 7
> + &pdma0 6>;
> + dma-names = "tx", "rx";
> #address-cells = <1>;
> #size-cells = <0>;
> status = "disabled";
> @@ -246,8 +247,9 @@
> compatible = "samsung,exynos4210-spi";
> reg = <0x13930000 0x100>;
> interrupts = <0 67 0>;
> - tx-dma-channel = <&pdma1 7>; /* preliminary */
> - rx-dma-channel = <&pdma1 6>; /* preliminary */
> + dmas = <&pdma0 7
> + &pdma0 6>;
Shouldn't these be pdma1 as was earlier?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: Modify SPI nodes according generic DMA DT bindings
2013-03-05 10:06 ` Sachin Kamat
@ 2013-03-05 10:19 ` Padma Venkat
2013-03-05 10:24 ` Sylwester Nawrocki
1 sibling, 0 replies; 4+ messages in thread
From: Padma Venkat @ 2013-03-05 10:19 UTC (permalink / raw)
To: Sachin Kamat
Cc: Padmavathi Venna, linux-samsung-soc, devicetree-discuss,
linux-arm-kernel, sbkim73, broonie, kgene.kim, arnd, vinod.koul,
grant.likely
On Tue, Mar 5, 2013 at 3:36 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> On 5 March 2013 15:34, Padmavathi Venna <padma.v@samsung.com> wrote:
>> This patch removes custom way of adding spi dma channels and
>> adds according to new generic DMA DT bindings on samsung exynos4
>> and exynos5440 platforms.
>>
>> Signed-off-by: Padmavathi Venna <padma.v@samsung.com>
>> ---
>> arch/arm/boot/dts/exynos4.dtsi | 15 +++++++++------
>> arch/arm/boot/dts/exynos5440.dtsi | 5 +++--
>> 2 files changed, 12 insertions(+), 8 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
>> index 1a62bcf..2449651 100644
>> --- a/arch/arm/boot/dts/exynos4.dtsi
>> +++ b/arch/arm/boot/dts/exynos4.dtsi
>> @@ -235,8 +235,9 @@
>> compatible = "samsung,exynos4210-spi";
>> reg = <0x13920000 0x100>;
>> interrupts = <0 66 0>;
>> - tx-dma-channel = <&pdma0 7>; /* preliminary */
>> - rx-dma-channel = <&pdma0 6>; /* preliminary */
>> + dmas = <&pdma0 7
>> + &pdma0 6>;
>> + dma-names = "tx", "rx";
>> #address-cells = <1>;
>> #size-cells = <0>;
>> status = "disabled";
>> @@ -246,8 +247,9 @@
>> compatible = "samsung,exynos4210-spi";
>> reg = <0x13930000 0x100>;
>> interrupts = <0 67 0>;
>> - tx-dma-channel = <&pdma1 7>; /* preliminary */
>> - rx-dma-channel = <&pdma1 6>; /* preliminary */
>> + dmas = <&pdma0 7
>> + &pdma0 6>;
>
> Shouldn't these be pdma1 as was earlier?
Oops, It's my mistake. Will repost this.
Thanks
Padma
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: Modify SPI nodes according generic DMA DT bindings
2013-03-05 10:06 ` Sachin Kamat
2013-03-05 10:19 ` Padma Venkat
@ 2013-03-05 10:24 ` Sylwester Nawrocki
1 sibling, 0 replies; 4+ messages in thread
From: Sylwester Nawrocki @ 2013-03-05 10:24 UTC (permalink / raw)
To: Sachin Kamat, Padmavathi Venna
Cc: linux-samsung-soc, devicetree-discuss, linux-arm-kernel,
padma.kvr, sbkim73, broonie, kgene.kim, arnd, vinod.koul,
grant.likely
On 03/05/2013 11:06 AM, Sachin Kamat wrote:
> On 5 March 2013 15:34, Padmavathi Venna <padma.v@samsung.com> wrote:
>> This patch removes custom way of adding spi dma channels and
>> adds according to new generic DMA DT bindings on samsung exynos4
>> and exynos5440 platforms.
>>
>> Signed-off-by: Padmavathi Venna <padma.v@samsung.com>
>> ---
>> arch/arm/boot/dts/exynos4.dtsi | 15 +++++++++------
>> arch/arm/boot/dts/exynos5440.dtsi | 5 +++--
>> 2 files changed, 12 insertions(+), 8 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
...
>> @@ -246,8 +247,9 @@
>> compatible = "samsung,exynos4210-spi";
>> reg = <0x13930000 0x100>;
>> interrupts = <0 67 0>;
>> - tx-dma-channel = <&pdma1 7>; /* preliminary */
>> - rx-dma-channel = <&pdma1 6>; /* preliminary */
>> + dmas = <&pdma0 7
>> + &pdma0 6>;
>
> Shouldn't these be pdma1 as was earlier?
Yes, it should. And this is also what the SoC documentation says - SPI1 is
assigned to Peri DMA1.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-03-05 10:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-05 10:04 [PATCH] ARM: dts: Modify SPI nodes according generic DMA DT bindings Padmavathi Venna
2013-03-05 10:06 ` Sachin Kamat
2013-03-05 10:19 ` Padma Venkat
2013-03-05 10:24 ` Sylwester Nawrocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).