Re: [PATCH V2 3/4] watchdog: s3c2410_wdt: parse watchdog dt node to read PMU registers adresses

[Sachin Kamat <sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>]

On 27 September 2013 15:46, Leela Krishna Amudala <l.krishna-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> This patch parses the watchdog node to read pmu wdt sys registers addresses
> and do mask/unmask enable/disable of WDT in probe and s2r scenarios.
>
> Signed-off-by: Leela Krishna Amudala <l.krishna-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
>  .../devicetree/bindings/watchdog/samsung-wdt.txt   |   24 ++++-
>  drivers/watchdog/s3c2410_wdt.c                     |   94 ++++++++++++++++++--
>  2 files changed, 108 insertions(+), 10 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/samsung-wdt.txt b/Documentation/devicetree/bindings/watchdog/samsung-wdt.txt
> index 2aa486c..f78b802 100644
> --- a/Documentation/devicetree/bindings/watchdog/samsung-wdt.txt
> +++ b/Documentation/devicetree/bindings/watchdog/samsung-wdt.txt
> @@ -5,10 +5,30 @@ after a preset amount of time during which the WDT reset event has not
>  occurred.
>
>  Required properties:
> -- compatible : should be "samsung,s3c2410-wdt"
> +- compatible : should be "samsung,s3c2410-wdt" or "samsung,s3c5250-wdt"

It would also be helpful to mention the SoCs along with the compatibles strings.

>  - reg : base physical address of the controller and length of memory mapped
> -       region.
> +       region and additional (addresses and length of memory mapped regions
> +       of) PMU registers for masking/unmasking WDT only in case of Exynos5250 and 5420.
>  - interrupts : interrupt number to the cpu.
> +- reset-mask-bit: bit number in the PMU registers to program mask/unmask WDT (required only
> +       in case of Exynos5250 and 5420).
>
>  Optional properties:
>  - timeout-sec : contains the watchdog timeout in seconds.
> +
> +Examples:
> +
> +watchdog {

watchdog@101D0000

> +       compatible = "samsung,s3c2410-wdt";
> +       reg = <0x101D0000 0x100>;
> +       interrupts = <0 42 0>;
> +       status = "disabled";
> +};
> +
> +watchdog {

ditto

> +        compatible = "samsung,s3c5250-wdt";
> +        reg = <0x101D0000 0x100>, <0x10040408 0x4>, <0x1004040c 0x4>;

-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html