Re: [PATCH 7/7] ARM: dts: Add Samsung G2D DT bindings documentation

[Sachin Kamat <sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>]

[-- Attachment #1.1: Type: text/plain, Size: 2474 bytes --]

On Thursday, 14 February 2013, Sylwester Nawrocki <
sylvester.nawrocki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> On 02/06/2013 12:51 PM, Sachin Kamat wrote:
>>
>> Added documentaion about G2D bindings.
>
> s/documentaion/documentation

Ok.
>
>> Signed-off-by: Sachin Kamat<sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>> ---
>>   .../devicetree/bindings/gpu/samsung-g2d.txt        |   30
++++++++++++++++++++
>>   1 files changed, 30 insertions(+), 0 deletions(-)
>>   create mode 100644
Documentation/devicetree/bindings/gpu/samsung-g2d.txt
>>
>> diff --git a/Documentation/devicetree/bindings/gpu/samsung-g2d.txt
b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt
>> new file mode 100644
>> index 0000000..838b26b
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt
>> @@ -0,0 +1,30 @@
>> +* Samsung 2D Graphics Accelerator
>> +
>
>> +Samsung FIMG2D is a 2D graphics accelerator which supports Bit Block
Transfer.
>> +We set the drawing-context registers for configuring the rendering
parameters
>> +and then start rendering.
>> +The G2D has V4L2 as well as DRM framework based driver support.
>
> IMHO this whole paragraph is irrelevant and could be dropped.

Ok. Had formatted this based on mfc document.
>
>> +Required properties:
>> +  - compatible : value should be one among the following
>
> missing colon at the end of line ?

Hmm. I think so.

>
>> +       (a) "samsung,s5pv210-g2d" for G2D IP present in S5PV210&
 Exynos4210 SoC
>> +       (b) "samsung,exynos4212-g2d" for G2D IP present in Exynos4x12
SoCs
>> +       (b) "samsung,exynos5250-g2d" for G2D IP present in Exynos5250 SoC
>
> s/(b)/(c)

Yes, copy paste error :)

>
>> +
>> +  - reg : Physical base address of the IP registers and length of memory
>> +         mapped region.
>> +
>> +  - interrupts : G2D interrupt number to the CPU.
>> +
>> +Optional properties:
>> +  - samsung,power-domain : power-domain property defined with a phandle
>> +                          to respective power domain.
>> +
>> +Example:
>> +       g2d@12800000 {
>> +               compatible = "samsung,s5pv210-g2d";
>> +               reg =<0x12800000 0x1000>;
>> +               interrupts =<0 89 0>;
>> +               samsung,power-domain =<&pd_lcd0>;
>> +               status = "disabled";
>> +       };
>
> Otherwise looks good to me.

Thanks for reviewing. Does the filename look good or should it be
exynos-g2d?

Regards,
Sachin.

-- 
With warm regards,
Sachin

[-- Attachment #1.2: Type: text/html, Size: 3312 bytes --]

[-- Attachment #2: Type: text/plain, Size: 192 bytes --]

_______________________________________________
devicetree-discuss mailing list
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
https://lists.ozlabs.org/listinfo/devicetree-discuss