From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sachin Kamat Subject: Re: [PATCH 7/7] ARM: dts: Add Samsung G2D DT bindings documentation Date: Thu, 14 Feb 2013 21:15:51 +0530 Message-ID: References: <1360151477-26460-1-git-send-email-sachin.kamat@linaro.org> <1360151477-26460-8-git-send-email-sachin.kamat@linaro.org> <511C1462.5060106@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4175752102429326526==" Return-path: In-Reply-To: <511C1462.5060106-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Sylwester Nawrocki Cc: "kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org" , "patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , "inki.dae-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org" , "linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org" List-Id: devicetree@vger.kernel.org --===============4175752102429326526== Content-Type: multipart/alternative; boundary=f46d043c80264582bf04d5b127ae --f46d043c80264582bf04d5b127ae Content-Type: text/plain; charset=ISO-8859-1 On Thursday, 14 February 2013, Sylwester Nawrocki < sylvester.nawrocki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > On 02/06/2013 12:51 PM, Sachin Kamat wrote: >> >> Added documentaion about G2D bindings. > > s/documentaion/documentation Ok. > >> Signed-off-by: Sachin Kamat >> --- >> .../devicetree/bindings/gpu/samsung-g2d.txt | 30 ++++++++++++++++++++ >> 1 files changed, 30 insertions(+), 0 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/gpu/samsung-g2d.txt >> >> diff --git a/Documentation/devicetree/bindings/gpu/samsung-g2d.txt b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt >> new file mode 100644 >> index 0000000..838b26b >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt >> @@ -0,0 +1,30 @@ >> +* Samsung 2D Graphics Accelerator >> + > >> +Samsung FIMG2D is a 2D graphics accelerator which supports Bit Block Transfer. >> +We set the drawing-context registers for configuring the rendering parameters >> +and then start rendering. >> +The G2D has V4L2 as well as DRM framework based driver support. > > IMHO this whole paragraph is irrelevant and could be dropped. Ok. Had formatted this based on mfc document. > >> +Required properties: >> + - compatible : value should be one among the following > > missing colon at the end of line ? Hmm. I think so. > >> + (a) "samsung,s5pv210-g2d" for G2D IP present in S5PV210& Exynos4210 SoC >> + (b) "samsung,exynos4212-g2d" for G2D IP present in Exynos4x12 SoCs >> + (b) "samsung,exynos5250-g2d" for G2D IP present in Exynos5250 SoC > > s/(b)/(c) Yes, copy paste error :) > >> + >> + - reg : Physical base address of the IP registers and length of memory >> + mapped region. >> + >> + - interrupts : G2D interrupt number to the CPU. >> + >> +Optional properties: >> + - samsung,power-domain : power-domain property defined with a phandle >> + to respective power domain. >> + >> +Example: >> + g2d@12800000 { >> + compatible = "samsung,s5pv210-g2d"; >> + reg =<0x12800000 0x1000>; >> + interrupts =<0 89 0>; >> + samsung,power-domain =<&pd_lcd0>; >> + status = "disabled"; >> + }; > > Otherwise looks good to me. Thanks for reviewing. Does the filename look good or should it be exynos-g2d? Regards, Sachin. -- With warm regards, Sachin --f46d043c80264582bf04d5b127ae Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable

On Thursday, 14 February 2013, Sylwester Nawrocki <sylvester.nawrocki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wro= te:
> On 02/06/2013 12:51 PM, Sachin Kamat wrote:
>>
>= > Added documentaion about G2D bindings.
>
> s/documentaion/documentation

Ok.
>
>> Si= gned-off-by: Sachin Kamat<sac= hin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>> ---
>> =A0 .../devicetree= /bindings/gpu/samsung-g2d.txt =A0 =A0 =A0 =A0| =A0 30 ++++++++++++++++++++<= br> >> =A0 1 files changed, 30 insertions(+), 0 deletions(-)
>> = =A0 create mode 100644 Documentation/devicetree/bindings/gpu/samsung-g2d.tx= t
>>
>> diff --git a/Documentation/devicetree/bindings/gp= u/samsung-g2d.txt b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt >> new file mode 100644
>> index 0000000..838b26b
>>= ; --- /dev/null
>> +++ b/Documentation/devicetree/bindings/gpu/sam= sung-g2d.txt
>> @@ -0,0 +1,30 @@
>> +* Samsung 2D Graphic= s Accelerator
>> +
>
>> +Samsung FIMG2D is a 2D graphics accelerator= which supports Bit Block Transfer.
>> +We set the drawing-context= registers for configuring the rendering parameters
>> +and then s= tart rendering.
>> +The G2D has V4L2 as well as DRM framework based driver support.>
> IMHO this whole paragraph is irrelevant and could be dropped= .

Ok. Had formatted this based on mfc document.
>
>> = +Required properties:
>> + =A0- compatible : value should be one among the following
>= ;
> missing colon at the end of line ?

Hmm. I think so.
>
>> + =A0 =A0 =A0 (a) "samsung,s5pv210-g2d" for G2D= IP present in S5PV210& =A0Exynos4210 SoC
>> + =A0 =A0 =A0 (b) "samsung,exynos4212-g2d" for G2D IP pr= esent in Exynos4x12 SoCs
>> + =A0 =A0 =A0 (b) "samsung,exynos= 5250-g2d" for G2D IP present in Exynos5250 SoC
>
> s/(b)/(= c)

Yes, copy paste error :)

>
>> +
>> + =A0- reg := Physical base address of the IP registers and length of memory
>>= + =A0 =A0 =A0 =A0 mapped region.
>> +
>> + =A0- interrup= ts : G2D interrupt number to the CPU.
>> +
>> +Optional properties:
>> + =A0- samsung,pow= er-domain : power-domain property defined with a phandle
>> + =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0to respective power domain.<= br>>> +
>> +Example:
>> + =A0 =A0 =A0 g2d@12800000 {
>> + =A0 =A0 =A0 =A0 =A0 =A0= =A0 compatible =3D "samsung,s5pv210-g2d";
>> + =A0 =A0 = =A0 =A0 =A0 =A0 =A0 reg =3D<0x12800000 0x1000>;
>> + =A0 =A0= =A0 =A0 =A0 =A0 =A0 interrupts =3D<0 89 0>;
>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 samsung,power-domain =3D<&pd_= lcd0>;
>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 status =3D "disabl= ed";
>> + =A0 =A0 =A0 };
>
> Otherwise looks good= to me.

Thanks for reviewing. Does the filename look good or should = it be exynos-g2d?

Regards,
Sachin.

--
With warm regards,
Sachin

--f46d043c80264582bf04d5b127ae-- --===============4175752102429326526== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ devicetree-discuss mailing list devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org https://lists.ozlabs.org/listinfo/devicetree-discuss --===============4175752102429326526==--