From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sachin Kamat Subject: Re: [PATCH 5/6] thermal:exynos4: Enable support for Exynos4412 SoCs Date: Mon, 22 Apr 2013 12:10:06 +0530 Message-ID: References: <1366389493-8239-1-git-send-email-l.majewski@samsung.com> <1366389493-8239-6-git-send-email-l.majewski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org To: amit kachhap Cc: Lukasz Majewski , Kukjin Kim , Mike Turquette , Zhang Rui , devicetree-discuss@lists.ozlabs.org, linux-samsung-soc@vger.kernel.org, Linux PM list , Kyungmin Park List-Id: devicetree@vger.kernel.org On 22 April 2013 11:55, amit kachhap wrote: > Hi, > > I have one suggestion, > > On Fri, Apr 19, 2013 at 10:08 PM, Lukasz Majewski > wrote: >> Enable TMU support for Exynos4412 based target with device tree. >> >> Signed-off-by: Lukasz Majewski >> Signed-off-by: Kyungmin Park >> --- >> drivers/thermal/exynos_thermal.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/thermal/exynos_thermal.c b/drivers/thermal/exynos_thermal.c >> index e922fa4..f54066d 100644 >> --- a/drivers/thermal/exynos_thermal.c >> +++ b/drivers/thermal/exynos_thermal.c >> @@ -819,6 +819,10 @@ static const struct of_device_id exynos_tmu_match[] = { >> .data = (void *)EXYNOS4210_TMU_DRV_DATA, >> }, >> { >> + .compatible = "samsung,exynos4412-tmu", >> + .data = (void *)EXYNOS_TMU_DRV_DATA, >> + }, > Instead of adding a new compatible string, "exynos5250-tmu" name can > be re-used in the 4412 DT node file as 4412 and 5250 TMU controller > are same. In cases where they are the same, it was generally the previous version of SoC that was added to the compatible list and re-used in the higher ones. IIRC, in cases where exynos5 based string was already defined a separate compatible string was added for exynos4 too (even if they used same driver data). -- With warm regards, Sachin