From: Daniel Vetter <daniel@ffwll.ch>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: devicetree <devicetree@vger.kernel.org>,
Emil Velikov <emil.l.velikov@gmail.com>,
Liviu Dudau <Liviu.Dudau@arm.com>,
LKML <linux-kernel@vger.kernel.org>,
DRI devel <dri-devel@lists.freedesktop.org>,
Rob Herring <robh+dt@kernel.org>,
LAKML <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 2/3] drm/arm: Add support for Mali Display Processors
Date: Wed, 15 Jun 2016 22:30:36 +0200 [thread overview]
Message-ID: <CAKMK7uFwXzRmLp_werouyvFrb-qEZi+xg32bO48r51rHmvT3Vw@mail.gmail.com> (raw)
In-Reply-To: <20160615200539.GH1041@n2100.armlinux.org.uk>
On Wed, Jun 15, 2016 at 10:05 PM, Russell King - ARM Linux
<linux@armlinux.org.uk> wrote:
> On Wed, Jun 15, 2016 at 09:29:38PM +0200, Daniel Vetter wrote:
>> On Wed, Jun 15, 2016 at 7:21 PM, Liviu Dudau <Liviu.Dudau@arm.com> wrote:
>> > Could be the tda998x_drv fault, but I'm getting this splat:
>>
>> Yeah, tda9998x needs to be fixed to _not_ register it's connector
>> before the overall (componentized) driver is ready. We need to make
>> sure first ofc that all users of that driver do register connectors,
>> but Chris' patch series will take care of that. But tda9998x needs to
>> be fixed either way.
>
> Componentised drivers only get one bind callback, they don't get a
> two-stage initialisation at bind time.
We don't need two-stage init in the component framework. There's
patches in-flight to simplify this a lot (and provide callbacks to
register additional connector interfaces like backlight). But in
general components should not call drm_connector_register, instead the
master should call drm_connector_register_all at the very end. Yes
this is a change from how all the original kms drivers have done it,
but that way was also racy (since it exposed interfaces to userspace
before they're fully set up). We're gradually switching each driver
over, but for shared bits like tda9998x it's a bit more complicated -
all the drivers using it need to switch at the same time.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-06-15 20:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 14:51 [PATCH v5 0/3] Add support for ARM Mali Display Processors Liviu Dudau
2016-06-15 14:51 ` [PATCH v5 1/3] dt/bindings: display: Add DT bindings for " Liviu Dudau
2016-06-15 14:51 ` [PATCH v5 2/3] drm/arm: Add support " Liviu Dudau
[not found] ` <1466002295-24813-3-git-send-email-Liviu.Dudau-5wv7dgnIgG8@public.gmane.org>
2016-06-15 15:23 ` Daniel Vetter
2016-06-15 16:17 ` Liviu Dudau
2016-06-15 17:13 ` Daniel Vetter
2016-06-15 17:14 ` Daniel Vetter
2016-06-15 17:21 ` Liviu Dudau
2016-06-15 17:35 ` Chris Wilson
2016-06-15 17:41 ` Liviu Dudau
2016-06-15 19:29 ` Daniel Vetter
[not found] ` <CAKMK7uGFTmQERWcDeQ=V-ntbgQv6K1avGx1LKCGLcAWacmHKnA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-06-15 20:05 ` Russell King - ARM Linux
2016-06-15 20:30 ` Daniel Vetter [this message]
2016-06-15 20:11 ` Russell King - ARM Linux
2016-06-16 7:57 ` Liviu Dudau
2016-06-15 14:51 ` [PATCH v5 3/3] MAINTAINERS: Add entry for Mali-DP driver Liviu Dudau
[not found] ` <1466002295-24813-4-git-send-email-Liviu.Dudau-5wv7dgnIgG8@public.gmane.org>
2016-06-15 15:35 ` Eric Engestrom
2016-06-15 16:12 ` Daniel Vetter
2016-06-15 16:21 ` Liviu Dudau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKMK7uFwXzRmLp_werouyvFrb-qEZi+xg32bO48r51rHmvT3Vw@mail.gmail.com \
--to=daniel@ffwll.ch \
--cc=Liviu.Dudau@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).