From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C253C433B4 for ; Thu, 6 May 2021 17:21:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 37CD861008 for ; Thu, 6 May 2021 17:21:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236240AbhEFRW3 (ORCPT ); Thu, 6 May 2021 13:22:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235881AbhEFRW1 (ORCPT ); Thu, 6 May 2021 13:22:27 -0400 Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [IPv6:2607:f8b0:4864:20::b32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46F6EC061763 for ; Thu, 6 May 2021 10:21:29 -0700 (PDT) Received: by mail-yb1-xb32.google.com with SMTP id z1so8358833ybf.6 for ; Thu, 06 May 2021 10:21:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sartura-hr.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WFWC5fpqRaGTrdHip1X5fLtWHN0bHh1jKIs9xXOqvCo=; b=gIZdu0zr3ZpqagrNEPWKcIoKlDQ3CN3N4AfPVFDzDwIzpjXbYoPYUXkop+y/aLEtfz 3ettPFVeGcLlr4fq/lsEw/tIMWiYKroW2ITLgrbICh3bDGmgLCVh6HAKLS5dpdQCbaVy TCIFNQayODjdnB/b9uuRoOQgHzdMgPjVIV28h1P3VJF4tAUmlXEa2xB98R9EEl31VcO1 lOmjoaGvnJE9sbfUTDEQ/2zk2O/nnntaNJHqYHPyuQXesjFftBABGdTFcO1IzothY6X2 OVwnFlQeHYu6d67xD5WlSGxktHzDZw59uV4aqO6sldVr0vaeBBTGfaDNPmcTqipGzS7+ dJ2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WFWC5fpqRaGTrdHip1X5fLtWHN0bHh1jKIs9xXOqvCo=; b=rFGg19DXKYnRFEhsLIdPjU4rDjqi4kJA6AISTZiQ9nb9O5vKp2bW3yG35gw7gUiiOY Gub2RiLutjq8CiOZbbSy35FhKMTKoDoQGl4f7KlMBvtnjRzAcwA9tYg6/0vvs+30JxH1 cOMddQLhtPnGwbOHCIQLXTE4tI7k1/lPYY3tALtca9TJYwzXf5H+TN8BwaGNmjcAFCRW 4GejNVAeQwT9SCl0CEsBUGFly8c8RTNHsjC/2lUir/C+6qhoEoUHLShdZhDOnhnBUROL 8aNeOkwarQ0Gul9xDgkxo/iOeIH9c1Bb10cAyw6dCBHrThkXGuW0/kp8ps/l0C5FWrOS QZDQ== X-Gm-Message-State: AOAM532O3EtLurnhr4qyXFMv/gCGV45zGFCAOqxXOrEXlKHS3ZBHTKnT 0BeWzRmSZw97iIGAsfUFRGOs1vY9FKwRpJt1IRsA1w== X-Google-Smtp-Source: ABdhPJxLhId8udASljWKtWTJzDPUFg816nivtvIYhzWVhtN58/ebBXiVacPTAsp7k3xt4DZI1GvNbhhx7lELMqrLl6k= X-Received: by 2002:a05:6902:102d:: with SMTP id x13mr7583894ybt.40.1620321688463; Thu, 06 May 2021 10:21:28 -0700 (PDT) MIME-Version: 1.0 References: <20210430123511.116057-1-robert.marko@sartura.hr> <20210430123511.116057-3-robert.marko@sartura.hr> <20210506140024.GB3340759@robh.at.kernel.org> <3905879e67d50d6a7f73fcd83982c052@walle.cc> In-Reply-To: <3905879e67d50d6a7f73fcd83982c052@walle.cc> From: Luka Perkov Date: Thu, 6 May 2021 19:21:17 +0200 Message-ID: Subject: Re: [PATCH 3/6] gpio: Add Delta TN48M CPLD GPIO driver To: Michael Walle Cc: Rob Herring , Robert Marko , lee.jones@linaro.org, linus.walleij@linaro.org, bgolaszewski@baylibre.com, jdelvare@suse.com, linux@roeck-us.net, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-hwmon@vger.kernel.org, Jonathan Polom , Paul Menzel , Donald Buczek , =?UTF-8?B?Q0xFTUVOVC5DSEFORyDlvLXlvJjmhbY=?= , upstream-wg@lists.dent.dev Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hello Michael, On Thu, May 6, 2021 at 6:40 PM Michael Walle wrote: > > Am 2021-05-06 16:00, schrieb Rob Herring: > > On Fri, Apr 30, 2021 at 02:35:08PM +0200, Robert Marko wrote: > >> Delta TN48M CPLD is used as a GPIO expander for the SFP GPIOs. > >> > >> It is a mix of input only and output only pins. > >> > >> Since there is no logical GPIO numbering arbitrary one is used > >> along dt-bindings to make it humanly readable. > >> > >> Signed-off-by: Robert Marko > >> --- > >> drivers/gpio/Kconfig | 12 +++ > >> drivers/gpio/Makefile | 1 + > >> drivers/gpio/gpio-tn48m.c | 191 > >> ++++++++++++++++++++++++++++++++++++++ > >> drivers/mfd/tn48m-cpld.c | 6 +- > >> include/linux/mfd/tn48m.h | 3 + > >> 5 files changed, 212 insertions(+), 1 deletion(-) > >> create mode 100644 drivers/gpio/gpio-tn48m.c > > > > > >> +static const struct platform_device_id tn48m_gpio_id_table[] = { > >> + { "delta,tn48m-gpio", }, > > > > Looks like a compatible, but is not. I think you can drop this and just > > use 'tm48m-gpio' (the driver name). > > I'm just curious, why isn't the vendor included here (as there > might be a chance for name clashes in the future). I'm looping in Clement from Delta as well as the Upstream Working Group from DENT [0]. Thanks, Luka [0] https://dent.dev/