Re: [PATCH v1 1/2] drm/sprd: remove the selected DRM_KMS_CMA_HELPER in kconfig

[Lukas Bulwahn <lukas.bulwahn@gmail.com>]

On Fri, Dec 24, 2021 at 3:12 PM Kevin Tang <kevin3.tang@gmail.com> wrote:
>
> On linux-next, commit 43531edd53f0 ("drm/sprd: add Unisoc's drm kms master") adds the config DRM_SPRD,
> which selects DRM_KMS_CMA_HELPER.
>

That this commit is _currently_ on linux-next is just a matter of the
current state. The commit message that goes into the project's history
should probably not state "on linux-next";
this information is probably outdated or of no interest to any further
future reader at the time of reading.

So, just drop "On linux-next". The commit 43531edd53f0 ("drm/sprd: add
Unisoc's drm kms master") will exist until the end of time.

> However, commit 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option") just removed the
> DRM_KMS_CMA_HELPER. So, the select DRM_KMS_CMA_HELPER refers to a non-existing kconfig symbol.
>

I would be happy about acknowledging my work of reporting with a
Reported-by tag, although I accidently send the report only to you
without cc-ing the mailing lists.

Please add:
Reported-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>

That said you may also add a Reviewed-by tag now:
Reviewed-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>


Lukas

> Cc: Orson Zhai <orsonzhai@gmail.com>
> Cc: Chunyan Zhang <zhang.lyra@gmail.com>
> Signed-off-by: Kevin Tang <kevin.tang@unisoc.com>
> ---
>  drivers/gpu/drm/sprd/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/sprd/Kconfig b/drivers/gpu/drm/sprd/Kconfig
> index 3edeaeca0..9a9c7ebfc 100644
> --- a/drivers/gpu/drm/sprd/Kconfig
> +++ b/drivers/gpu/drm/sprd/Kconfig
> @@ -3,7 +3,6 @@ config DRM_SPRD
>         depends on ARCH_SPRD || COMPILE_TEST
>         depends on DRM && OF
>         select DRM_GEM_CMA_HELPER
> -       select DRM_KMS_CMA_HELPER
>         select DRM_KMS_HELPER
>         select DRM_MIPI_DSI
>         select VIDEOMODE_HELPERS
> --
> 2.29.0
>