From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <devicetree-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id B511FC3DA7A
	for <linux-devicetree@archiver.kernel.org>; Sun, 25 Dec 2022 17:07:08 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231271AbiLYRHH (ORCPT
        <rfc822;linux-devicetree@archiver.kernel.org>);
        Sun, 25 Dec 2022 12:07:07 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46058 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S231191AbiLYRHC (ORCPT
        <rfc822;devicetree@vger.kernel.org>); Sun, 25 Dec 2022 12:07:02 -0500
Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26AA83B4
        for <devicetree@vger.kernel.org>; Sun, 25 Dec 2022 09:06:56 -0800 (PST)
Received: by mail-ej1-x630.google.com with SMTP id x22so22239760ejs.11
        for <devicetree@vger.kernel.org>; Sun, 25 Dec 2022 09:06:56 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=kali.org; s=google;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=vyDyfKRe4UciHLbWhp5EP/ZhHAR/iZg7adKyYym7xzY=;
        b=N4QcCUEG2b8wZOSRUGbQHEasDbDcOxPvvwT8t3U8oYzVSvInG5+110rCSiI9rP/ReG
         hCdVnmCzCISjX40Dt3IiLQ7cRo2jWEdwpI5zUkfMxXPmsK3yWtTGojAF9OImQxOe7f+a
         NQNWSOZ22Z4ezO3hYUp+lM4aHTNLl+G91YwKy7SwywuO/O6EJ9lAmhfOGEa0Mthe63vS
         ekXqsr9VDEbnsDwEOxLhI0J83jdSBBJ6aXSpZEc63q2IoiJZ8Jf8chO30iAM6Fb87dsJ
         jPYTjRSl+S63jqn3fdPO48Zvxy78A/seAKYzsFV+XAfqKEpY+W3Lm1GkrZ2Tk5eYI+MM
         kCiA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=vyDyfKRe4UciHLbWhp5EP/ZhHAR/iZg7adKyYym7xzY=;
        b=aY5g4MyDnemivACT9k6550+2y7Qdgg7gHLGy1lBWQ8QBQu0Z2CwgvIsor3sC+GI/7u
         XEYa3IxJErr65YfL0zDrgFBssrNCZum0gZy1FDqpq38PtRFWBiNnxozlzb5SYkJJcxrg
         RGWAby4BjRuY8BnIOPoyWCD1vgrGYh3URLrm4/PkrbSoLtUMM8K2hzyA5QhfyIeKV025
         DpeqAR8liuj5xxdUDyvVn1pa3y8jMwRShvtT/2EjQZxY/5QIXFf4w2DMg27OOP56cKK0
         Wh9T/hhXlQMHmWaAsUYDoBXCaP5qvLwEHr8mHeypDh5wJ+BgkoY5Kfr1k7Tum83fv1ud
         iUIA==
X-Gm-Message-State: AFqh2kpQhRy5oFlHBBdUgi0DgidV2xoXTSlryjmakE27KFOJ2zPm5+dt
        b/D1DKfylNYPBcjozkZ49xQvJO6JaIM/oW5G0vlJB5uwcRSEdQ==
X-Google-Smtp-Source: AMrXdXtOvc9dlNwPaScI0wSXynsYQ7+IqTsTIyB525hizm7bv+IyI2UsppjW9+rsTRedl4krrJ/m5q6e6bEowJCO9TY=
X-Received: by 2002:a17:907:1703:b0:7c0:b569:8efd with SMTP id
 le3-20020a170907170300b007c0b5698efdmr1965453ejc.652.1671988014767; Sun, 25
 Dec 2022 09:06:54 -0800 (PST)
MIME-Version: 1.0
References: <20221225040821.8395-1-steev@kali.org> <CAA8EJpqD6pvZjXa4_cQ=02o_Ns94LAJ3n-S2Q8LjfqOySgHHfA@mail.gmail.com>
In-Reply-To: <CAA8EJpqD6pvZjXa4_cQ=02o_Ns94LAJ3n-S2Q8LjfqOySgHHfA@mail.gmail.com>
From:   Steev Klimaszewski <steev@kali.org>
Date:   Sun, 25 Dec 2022 11:06:30 -0600
Message-ID: <CAKXuJqhHF6FCe26KKoFMHnKgoV3WifveQYq5FyiGKHPbvHXPyA@mail.gmail.com>
Subject: Re: [PATCH 26/26] arm64: dts: qcom: c630: set venus firmware name
To:     Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk
List-ID: <devicetree.vger.kernel.org>
X-Mailing-List: devicetree@vger.kernel.org

On Sun, Dec 25, 2022 at 9:22 AM Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:
>
> On Sun, 25 Dec 2022 at 06:08, Steev Klimaszewski <steev@kali.org> wrote:
> >
> > The Lenovo Yoga C630 can't use the generic venus firmware that is in the
> > linux-firmware repository, and needs a signed one.  This file is
> > qcvss850.mbn from the Windows partition and needs to be copied manually.
> >
> > Signed-off-by: Steev Klimaszewski <steev@kali.org>
> > ---
> >  arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> > index 7e80e2950f8d..78a14f899df9 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> > +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
> > @@ -801,6 +801,7 @@ &usb_2_qmpphy {
> >  };
> >
> >  &venus {
> > +       firmware-name = "qcom/venus-5.2/qcvss850.mbn";
>
> Please follow the established convention (see e.g. the x13s laptop firmware).
> It should be "qcom/sdm850/LENOVO/81JL/qcvss850.mbn" (or
> qcom/sdm845/LENOVO/....).
>
> >         status = "okay";
> >  };
> >
> > --
> > 2.35.1
> >
>
>
> --
> With best wishes
> Dmitry

Thanks for pointing that out; will make the change for v2!