From: gyeyoung <gye976@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: jic23@kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, lars@metafoo.de,
gustavograzs@gmail.com, javier.carrasco.cruz@gmail.com,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 3/3] dt-bindings: add winsen to the vendor prefixes
Date: Mon, 31 Mar 2025 09:13:21 +0900 [thread overview]
Message-ID: <CAKbEzntatDQHoUcnESxLwuNwtfvb4BWH4d4Bwxen95RESHHtbg@mail.gmail.com> (raw)
In-Reply-To: <864f223f-2d0b-4202-b46d-824ee61fc817@kernel.org>
Hello Krzysztof, thank you for the review.
On Sun, Mar 30, 2025 at 6:37 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 29/03/2025 17:49, Gyeyoung Baek wrote:
> > Add winsen to the vendor prefixes.
> >
> > Signed-off-by: Gyeyoung Baek <gye976@gmail.com>
> > ---
> Your patches are ordered entirely in opposite order. First you use the
> binding, then you document. First you use prefix, then you document it.
>
> It's not bisectable. Reverse everything (see also DT submitting patches).
On second thought, reverse order makes more sense. thanks.
> Best regards,
> Krzysztof
Thanks,
Gyeyoung Baek
prev parent reply other threads:[~2025-03-31 0:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-29 16:49 [PATCH 0/3] add support for winsen MHZ19B CO2 sensor Gyeyoung Baek
2025-03-29 16:49 ` [PATCH 1/3] iio: chemical: " Gyeyoung Baek
2025-03-30 14:04 ` Jonathan Cameron
2025-03-31 14:36 ` gyeyoung
2025-04-04 11:39 ` Jonathan Cameron
2025-03-29 16:49 ` [PATCH 2/3] dt-bindings: add device tree " Gyeyoung Baek
2025-03-30 9:39 ` Krzysztof Kozlowski
2025-03-31 1:11 ` gyeyoung
2025-03-30 12:50 ` Jonathan Cameron
2025-03-31 1:32 ` gyeyoung
2025-03-29 16:49 ` [PATCH 3/3] dt-bindings: add winsen to the vendor prefixes Gyeyoung Baek
2025-03-30 9:37 ` Krzysztof Kozlowski
2025-03-31 0:13 ` gyeyoung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKbEzntatDQHoUcnESxLwuNwtfvb4BWH4d4Bwxen95RESHHtbg@mail.gmail.com \
--to=gye976@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gustavograzs@gmail.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).