From: Alistair Francis <alistair23@gmail.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Mark Brown <broonie@kernel.org>,
Alistair Francis <alistair@alistair23.me>,
Rob Herring <robh+dt@kernel.org>,
lgirdwood@gmail.com, dl-linux-imx <linux-imx@nxp.com>,
Sascha Hauer <kernel@pengutronix.de>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v9 03/12] mfd: simple-mfd-i2c: Save the register client data
Date: Tue, 10 Aug 2021 17:03:34 +1000 [thread overview]
Message-ID: <CAKmqyKMtFYC8KN4pD-8cnUQq39WmOJHDotK6FT2BsisOoM2=8w@mail.gmail.com> (raw)
In-Reply-To: <YREOMY4Q5xY8Qn9N@google.com>
On Mon, Aug 9, 2021 at 9:14 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> On Fri, 06 Aug 2021, Mark Brown wrote:
>
> > On Fri, Aug 06, 2021 at 12:38:36PM +0100, Lee Jones wrote:
> > > On Fri, 06 Aug 2021, Alistair Francis wrote:
> >
> > > > + i2c_set_clientdata(i2c, regmap);
> > > > +
> >
> > > No need to store this here.
> >
> > > Just do this in the child device:
> >
> > > dev_get_regmap(pdev->dev.parent, NULL);
> >
> > Note that dev_get_regmap() is relatively expensive compared to a simple
> > driver data reference since it needs to go search for the device to find
> > the regmap, it's not the end of the world especially in the context of
> > doing I2C I/O but storing it isn't a terrible idea.
>
> It would be nice if someone could do some metrics on this.
I updated it to use `dev_get_regmap()` in version 10 of the series
Alistair
>
> --
> Lee Jones [李琼斯]
> Senior Technical Lead - Developer Services
> Linaro.org │ Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-08-10 7:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 9:10 [PATCH v9 00/12] Add support for the silergy,sy7636a Alistair Francis
2021-08-06 9:10 ` [PATCH v9 01/12] dt-bindings: mfd: Initial commit of silergy,sy7636a.yaml Alistair Francis
2021-08-06 9:10 ` [PATCH v9 02/12] mfd: simple-mfd-i2c: Add a Kconfig name Alistair Francis
2021-08-06 11:39 ` Lee Jones
2021-08-06 11:47 ` Alistair Francis
2021-08-06 9:10 ` [PATCH v9 03/12] mfd: simple-mfd-i2c: Save the register client data Alistair Francis
2021-08-06 11:38 ` Lee Jones
2021-08-06 11:45 ` Mark Brown
2021-08-09 11:14 ` Lee Jones
2021-08-10 7:03 ` Alistair Francis [this message]
2021-08-06 9:10 ` [PATCH v9 04/12] mfd: simple-mfd-i2c: Enable support for the silergy,sy7636a Alistair Francis
2021-08-06 11:39 ` Lee Jones
2021-08-06 9:10 ` [PATCH v9 05/12] regulator: sy7636a: Use the regmap directly Alistair Francis
2021-08-06 9:10 ` [PATCH v9 06/12] regulator: sy7636a: Remove requirement on sy7636a mfd Alistair Francis
2021-08-06 9:10 ` [PATCH v9 07/12] thermal: sy7636a: Add thermal driver for sy7636a Alistair Francis
2021-08-06 9:10 ` [PATCH v9 08/12] hwmon: sy7636a: Add temperature " Alistair Francis
2021-08-06 9:10 ` [PATCH v9 09/12] ARM: imx_v6_v7_defconfig: Enable silergy,sy7636a Alistair Francis
2021-08-06 9:10 ` [PATCH v9 10/12] ARM: dts: imx7d: remarkable2: " Alistair Francis
2021-08-06 9:10 ` [PATCH v9 11/12] ARM: imx_v6_v7_defconfig: Enable backlight class devices Alistair Francis
2021-08-06 9:10 ` [PATCH v9 12/12] ARM: dts: imx7d: remarkable2: Enable lcdif Alistair Francis
2021-08-09 13:06 ` (subset) [PATCH v9 00/12] Add support for the silergy,sy7636a Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKmqyKMtFYC8KN4pD-8cnUQq39WmOJHDotK6FT2BsisOoM2=8w@mail.gmail.com' \
--to=alistair23@gmail.com \
--cc=alistair@alistair23.me \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).